-
Notifications
You must be signed in to change notification settings - Fork 182
feat: Sync units in course outline [FC-0083] #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sync units in course outline [FC-0083] #1850
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1850 +/- ##
==========================================
- Coverage 93.77% 93.77% -0.01%
==========================================
Files 1146 1146
Lines 23881 23903 +22
Branches 5134 5042 -92
==========================================
+ Hits 22394 22414 +20
- Misses 1411 1421 +10
+ Partials 76 68 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pomegranited
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works great @ChrisChV !
- I tested this using the PR test instructions
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
-
Includes documentation - User-facing strings are extracted for translation
|
@ChrisChV Can you please rebase this or update it with master? |
bradenmacdonald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and is working, though I couldn't test it with all the other changes that recently merged. Please rebase / merge master, then do a quick test of the functionality before you merge.
|
Sure |
|
@bradenmacdonald I can confirm that it works! 🎉 |
|
This doesn't make sense - the coverage of this PR is 100% but it's complaining that it reduces the project coverage? Maybe rebase and squash? Edit: Oh, it's because of "indirect changes" to |
Yes, it has happened to me a few times, I'm going to do the rebase and squash |
e4e4b66 to
8557ccb
Compare
8557ccb to
c13806a
Compare
Description
https://www.loom.com/share/70a14ccdb2ae487ea769be340d6ba845?sid=752e2e84-3553-4306-ad71-d21e40e4a682
Supporting information
Testing instructions
Accept changesbutton.Ignore changesbutton.Other information