-
Notifications
You must be signed in to change notification settings - Fork 182
feat: Add unit from library in course [FC-0083] #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add unit from library in course [FC-0083] #1829
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1829 +/- ##
==========================================
+ Coverage 93.68% 93.74% +0.06%
==========================================
Files 1142 1146 +4
Lines 23479 23824 +345
Branches 5050 5127 +77
==========================================
+ Hits 21996 22334 +338
- Misses 1407 1414 +7
Partials 76 76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Wouldn't we want to show only the "Units" tab instead of "Home"? |
|
@ChrisChV Since we might not be able to merge this for another couple days, until the backend PRs are ready, could you make a video demo of it and post that on the issue, so the UX team can start reviewing it based on the video? |
pomegranited
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works great thank you @ChrisChV !
- I tested this using the PR test instructions
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
-
Includes documentationN/A - User-facing strings are extracted for translation
86c7c57 to
dc557cb
Compare
It's not a blocker, but I didn't get an answer to this question? |
bradenmacdonald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and seems to work well, thanks! Tested with openedx/openedx-platform#36553
I just pushed one little comment-only documentation about Vertical: 6ac9094
@bradenmacdonald Yes, it's possible, I'm on it, I'll have it ready in 10 minutes |
|
@ChrisChV We can also do it in a follow-up PR if you want - this one is ready to merge and I'm about to merge the platform PR it needs :) |
@bradenmacdonald Sorry, I had it almost done :) It's on cc950a3, you can check it. It's a simple refactor |
c41e4ea to
cc950a3
Compare
|
Nice, thanks @ChrisChV! 👍🏻 |

Description
Use unit from librarybutton in the subsection card in the Course OutlineshowOnlyHomeTabinComponentPickerto only show the home tab to avoid showingcollectionsorcomponentstabs in the unit picker.https://www.loom.com/share/1133a3dfbbd349b18c7cf4aca2023e78?sid=068b4d45-88af-4eef-8e78-a070cbe01325
Supporting information
Testing instructions
edx-platform, use this branch which already contains both branches togethermake requirementson cms and lms shells to install the new version of opaque-keysmake migrateon cms-shell.tutor dev exec cms ./manage.py cms reindex_studio --experimentalUse unit from library.Other information