-
Notifications
You must be signed in to change notification settings - Fork 21
feat: context key property for new container locator keys #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: context key property for new container locator keys #375
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 93.84% 93.64% -0.21%
==========================================
Files 31 31
Lines 3007 3022 +15
Branches 192 192
==========================================
+ Hits 2822 2830 +8
- Misses 159 165 +6
- Partials 26 27 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
29816d9 to
e9f7d4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it from the discussion on openedx/frontend-app-authoring#1711 (comment), we will not need to emulate container keys as usage keys, so I think we can close this PR in favor of openedx/openedx-platform#36553, right?
164c047 to
1eb8b90
Compare
|
@kdmccormick Yes, we don't need most of it but adding context_key property to container keys is useful. |
|
Closing in favor of #379 |
All keys for content items inside a learning context should have the
.context_keyproperty to get the parent learning context, but some of the new library keys were missing this.Adds a new Django field type that can store
LibraryItemKey(Collection or Container keys). (TODO: this should probably be able to hold library usage keys too, since those are also library items)