Skip to content

Conversation

@navinkarkera
Copy link

@navinkarkera navinkarkera commented Apr 20, 2025

  1. All keys for content items inside a learning context should have the .context_key property to get the parent learning context, but some of the new library keys were missing this.

  2. Adds a new Django field type that can store LibraryItemKey (Collection or Container keys). (TODO: this should probably be able to hold library usage keys too, since those are also library items)

@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.64%. Comparing base (15ae68c) to head (168abc6).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
opaque_keys/edx/locator.py 66.66% 2 Missing ⚠️
opaque_keys/edx/keys.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   93.84%   93.64%   -0.21%     
==========================================
  Files          31       31              
  Lines        3007     3022      +15     
  Branches      192      192              
==========================================
+ Hits         2822     2830       +8     
- Misses        159      165       +6     
- Partials       26       27       +1     
Flag Coverage Δ
unittests 93.64% <81.25%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it from the discussion on openedx/frontend-app-authoring#1711 (comment), we will not need to emulate container keys as usage keys, so I think we can close this PR in favor of openedx/openedx-platform#36553, right?

@navinkarkera navinkarkera force-pushed the navin/fal-4077/fix-new-locators branch from 164c047 to 1eb8b90 Compare April 23, 2025 05:21
@navinkarkera
Copy link
Author

@kdmccormick Yes, we don't need most of it but adding context_key property to container keys is useful.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 23, 2025
@navinkarkera
Copy link
Author

Closing in favor of #379

@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Apr 24, 2025
@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants