feat: disallow edits to units in courses that are sourced from a library#1833
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
3cdd8d3 to
38419fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1833 +/- ##
==========================================
+ Coverage 93.74% 93.76% +0.01%
==========================================
Files 1146 1146
Lines 23824 23881 +57
Branches 5022 5030 +8
==========================================
+ Hits 22334 22391 +57
Misses 1422 1422
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdac5f3 to
3dc2794
Compare
756dcaf to
49290ad
Compare
There was a problem hiding this comment.
@rpenido I had to fix a few things on the Course Outline page, and made sure that we're only disallowing edits on Units sourced from a library (lct:...).
Also -- we still need to be able to publish Units sourced from a library, we just can't edit them.
But this is working enough for now :)
TODO in a follow-up PR:
- If the upstream link is broken, allow edits.
👍
- I tested this using the PR test instructions on : units sourced from a library are read only, units copy/pasted from a course are editable, normal units are editable.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation -- code docs
- User-facing strings are extracted for translation
73a98f2 to
ebd8674
Compare
Fixes test broken by 76979e7.
ebd8674 to
1ff27c5
Compare
Description
This PR disallows edits to units in courses (including title change, children change) that are sourced from a library.
Supporting information
Testing instructions
Private ref: FAL-4112