feat: disallow edits to units in courses that are sourced from a library [FC-0083]#36558
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
and remove added parent_has_upstream Also fixes cause of some test failures.
pomegranited
left a comment
There was a problem hiding this comment.
@rpenido I fixed a couple things, but this is working as required :)
👍
- I tested this by running this code while testing openedx/frontend-app-authoring#1833
- I read through the code
-
I checked for accessibility issuesN/A - Includes documentation -- code comments
- User-facing strings are extracted for translation
| </li> | ||
| % endif | ||
| % elif not show_inline: | ||
| % elif not show_inline and not parent_has_upstream: |
There was a problem hiding this comment.
We already have a can_edit flag in the context, so we can use that instead of adding this parent_has_upstream flag.
Fixed with 29324b9.
|
Closing in favor of open-craft#774 |
Description
This PR disallows edits to units in courses (including title change, children change) that are sourced from a library.
Supporting information
Testing instructions
Check openedx/frontend-app-authoring#1833
Private ref: FAL-4112