Skip to content

feat: disallow edits to units in courses that are sourced from a library [FC-0083]#36558

Closed
rpenido wants to merge 49 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4112/disallow-edits-to-units-in-courses-from-libraries
Closed

feat: disallow edits to units in courses that are sourced from a library [FC-0083]#36558
rpenido wants to merge 49 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4112/disallow-edits-to-units-in-courses-from-libraries

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Apr 21, 2025

Description

This PR disallows edits to units in courses (including title change, children change) that are sourced from a library.

Supporting information

Testing instructions

Check openedx/frontend-app-authoring#1833


Private ref: FAL-4112

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 21, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 21, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 23, 2025
@rpenido rpenido changed the title feat: disallow edits to units in courses that are sourced from a library feat: disallow edits to units in courses that are sourced from a library [FC-0083] Apr 23, 2025
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido I fixed a couple things, but this is working as required :)

👍

  • I tested this by running this code while testing openedx/frontend-app-authoring#1833
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation -- code comments
  • User-facing strings are extracted for translation

</li>
% endif
% elif not show_inline:
% elif not show_inline and not parent_has_upstream:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a can_edit flag in the context, so we can use that instead of adding this parent_has_upstream flag.

Fixed with 29324b9.

@rpenido rpenido marked this pull request as ready for review April 24, 2025 09:33
@pomegranited
Copy link
Contributor

Closing in favor of open-craft#774

@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Apr 24, 2025
@rpenido rpenido deleted the rpenido/fal-4112/disallow-edits-to-units-in-courses-from-libraries branch April 28, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants