feat: disallow edits to units in courses that are sourced from a library [FC-0083]#774
Merged
pomegranited merged 7 commits intochris/FAL-4075-get-unit-updstreamfrom Apr 24, 2025
Conversation
and remove added parent_has_upstream Also fixes cause of some test failures.
…w-edits-to-units-in-courses-from-libraries
pomegranited
force-pushed
the
chris/FAL-4075-get-unit-updstream
branch
from
863c696 to
b248df6
Compare
…ts-to-units-in-courses-from-libraries' into jill/rpenido/fal-4112/disallow-edits-to-units-in-courses-from-libraries
pomegranited
force-pushed
the
jill/rpenido/fal-4112/disallow-edits-to-units-in-courses-from-libraries
branch
from
100a415 to
7e1168d
Compare
…o jill/rpenido/fal-4112/disallow-edits-to-units-in-courses-from-libraries
…ream' into jill/rpenido/fal-4112/disallow-edits-to-units-in-courses-from-libraries
pomegranited
merged commit 57b2205
into
chris/FAL-4075-get-unit-updstream
41 checks passed
pomegranited
deleted the
jill/rpenido/fal-4112/disallow-edits-to-units-in-courses-from-libraries
branch
ChrisChV
added a commit
that referenced
this pull request
Apr 24, 2025
) * feat: library unit sync * feat: create component link only for component xblocks * feat: container link model * feat: update downstream api views * feat: delete extra components in container on sync (not working) * fix: duplicate definitions of LibraryXBlockMetadata * test: add a new integration test suite for syncing * feat: partially implement container+child syncing * fix: blockserializer wasn't always serializing all HTML block fields * feat: handle reorder, addition and deletion of components in sync Updates children components of unit in course based on upstream unit, deletes removed component, adds new ones and updates order as per upstream. * feat: return unit upstreamInfo and disallow edits to units in courses that are sourced from a library (#773) * feat: Add upstream_info to unit * feat: disallow edits to units in courses that are sourced from a library (#774) --------- Co-authored-by: Jillian Vogel <jill@opencraft.com> Co-authored-by: Rômulo Penido <romulo.penido@gmail.com> * docs: capitalization of XBlock Co-authored-by: David Ormsbee <dave@axim.org> * refactor: (minor) change python property name to reflect type better * fix: lots of "Tried to inspect a missing...upstream link" warnings when viewing a unit in Studio * docs: mention potential REST API for future refactor * fix: check if upstream actually exists before making unit read-only * chore: fix camel-case var * fix: test failure when mocked XBlock doesn't have UpstreamSyncMixin --------- Co-authored-by: Braden MacDonald <braden@opencraft.com> Co-authored-by: Chris Chávez <xnpiochv@gmail.com> Co-authored-by: Jillian Vogel <jill@opencraft.com> Co-authored-by: Rômulo Penido <romulo.penido@gmail.com> Co-authored-by: Braden MacDonald <mail@bradenm.com> Co-authored-by: David Ormsbee <dave@axim.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR disallows edits to units in courses (including title change, children change) that are sourced from a library.
Supporting information
Testing instructions
Check openedx/frontend-app-authoring#1833
Private ref: FAL-4112