Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Assignment and course grade fields validations #366

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vladislavkeblysh
Copy link

  • Added min max validations to assignments grade fields
  • Added validations when min value must be less than max value

Screenshot 2023-10-21 at 15 02 27
Screenshot 2023-10-21 at 15 02 42

@vladislavkeblysh vladislavkeblysh requested a review from a team as a code owner October 24, 2023 18:54
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 24, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 24, 2023

Thanks for the pull request, @vladislavkeblysh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @farhaanbukhsh. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@vladislavkeblysh vladislavkeblysh changed the title feat: Assignment and course grade fields validations (palm.master) feat: Assignment and course grade fields validations Oct 24, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (a4eff69) to head (0b278b7).
Report is 21 commits behind head on master.

Current head 0b278b7 differs from pull request most recent head 890387e

Please upload reports for the commit 890387e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   94.98%   95.05%   +0.06%     
==========================================
  Files         140      140              
  Lines        1357     1375      +18     
  Branches      264      274      +10     
==========================================
+ Hits         1289     1307      +18     
  Misses         60       60              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 25, 2023
@mphilbrick211
Copy link

Hi @openedx/content-aurora! This is ready for review. Thanks!

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 15, 2023
@mphilbrick211
Copy link

Hi @arbrandes - are you able to review this for us? It's been stalled.

@arbrandes
Copy link
Contributor

Ok, I'll take a look!

In the meantime, @vladislavkeblysh, do you mind rebasing and/or resolving conflicts?

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/validation-for-assignments-master branch from 0b278b7 to 890387e Compare June 5, 2024 10:30
@mphilbrick211 mphilbrick211 requested review from farhaanbukhsh and removed request for a team July 30, 2024 20:34
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/validation-for-assignments-master branch from 890387e to 444c95b Compare July 31, 2024 13:41
@vladislavkeblysh
Copy link
Author

@arbrandes Done!

@farhaanbukhsh
Copy link
Member

@vladislavkeblysh I have tested the PR if you can rebase it and fix the tests we can be in a good position to merge it.

Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove package-lock.json since we are not adding any dependency in the project.

@farhaanbukhsh
Copy link
Member

hey @vladislavkeblysh , any updates?

@farhaanbukhsh
Copy link
Member

hey @vladislavkeblysh if you don't have time can I work on this PR and push it forward since it just requires a little push :) @arbrandes if I work on this can you make some time to review it since this is long pending?

@mphilbrick211
Copy link

hey @vladislavkeblysh if you don't have time can I work on this PR and push it forward since it just requires a little push :) @arbrandes if I work on this can you make some time to review it since this is long pending?

Hi @vladislavkeblysh @arbrandes - friendly ping on this ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

6 participants