-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Assignment and course grade fields validations #366
base: master
Are you sure you want to change the base?
feat: Assignment and course grade fields validations #366
Conversation
vladislavkeblysh
commented
Oct 24, 2023
- Added min max validations to assignments grade fields
- Added validations when min value must be less than max value
Thanks for the pull request, @vladislavkeblysh! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 94.98% 95.05% +0.06%
==========================================
Files 140 140
Lines 1357 1375 +18
Branches 264 274 +10
==========================================
+ Hits 1289 1307 +18
Misses 60 60
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Hi @openedx/content-aurora! This is ready for review. Thanks! |
Hi @arbrandes - are you able to review this for us? It's been stalled. |
Ok, I'll take a look! In the meantime, @vladislavkeblysh, do you mind rebasing and/or resolving conflicts? |
0b278b7
to
890387e
Compare
890387e
to
444c95b
Compare
@arbrandes Done! |
@vladislavkeblysh I have tested the PR if you can rebase it and fix the tests we can be in a good position to merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove package-lock.json since we are not adding any dependency in the project.
hey @vladislavkeblysh , any updates? |
hey @vladislavkeblysh if you don't have time can I work on this PR and push it forward since it just requires a little push :) @arbrandes if I work on this can you make some time to review it since this is long pending? |