-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Assignment and course grade fields validations (redwood.master) #396
base: open-release/redwood.master
Are you sure you want to change the base?
Conversation
vladislavkeblysh
commented
Jun 5, 2024
- Added min max validations to assignments grade fields
- Added validations when min value must be less than max value
…on-file Add renovate configuration file
feat: use frontend-plugin-framework to provide a FooterSlot
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
chore: Adds catalog-info.yml for the project
…ades-modal-rows-counter-olive fix: Fix rows counter in the Edit Grade modal window
Thanks for the pull request, @vladislavkeblysh! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @vladislavkeblysh! A few branch conflicts have popped up. |
Update codecov to the latest version and start using the org-wide token for uploads. See openedx/wg-frontend#179
Hi @vladislavkeblysh - friendly ping on this! |
154054e
to
6c472be
Compare
@mphilbrick211 done! |
@vladislavkeblysh there are still conflicts and tests failing can you please resolve them :) I can review it then :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the rebase didn't go the right way can you please check once.
spec: | ||
owner: user:farhaanbukhsh | ||
type: 'website' | ||
lifecycle: 'experimental' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not related to the PR
Based on #366 |