Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Assignment and course grade fields validations (redwood.master) #396

Open
wants to merge 10 commits into
base: open-release/redwood.master
Choose a base branch
from

Conversation

vladislavkeblysh
Copy link

  • Added min max validations to assignments grade fields
  • Added validations when min value must be less than max value

Screenshot 2023-10-21 at 15 02 27
Screenshot 2023-10-21 at 15 02 42

@vladislavkeblysh vladislavkeblysh requested a review from a team as a code owner June 5, 2024 11:28
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 5, 2024

Thanks for the pull request, @vladislavkeblysh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @farhaanbukhsh. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 5, 2024
@mphilbrick211
Copy link

Hi @vladislavkeblysh! A few branch conflicts have popped up.

Update codecov to the latest version and start using the org-wide token for uploads.

See openedx/wg-frontend#179
@mphilbrick211
Copy link

Hi @vladislavkeblysh! A few branch conflicts have popped up.

Hi @vladislavkeblysh - friendly ping on this!

@mphilbrick211 mphilbrick211 requested review from farhaanbukhsh and removed request for a team July 30, 2024 20:38
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/validation-for-assignments-redwood branch from 154054e to 6c472be Compare July 31, 2024 13:46
@vladislavkeblysh
Copy link
Author

@mphilbrick211 done!

@farhaanbukhsh
Copy link
Member

@vladislavkeblysh there are still conflicts and tests failing can you please resolve them :) I can review it then :)

Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the rebase didn't go the right way can you please check once.

spec:
owner: user:farhaanbukhsh
type: 'website'
lifecycle: 'experimental'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not related to the PR

@farhaanbukhsh
Copy link
Member

Based on #366

@mphilbrick211
Copy link

Hi @vladislavkeblysh @farhaanbukhsh! Is this still in progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

9 participants