-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add max value warning and disable the submit button #426
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @farhaanbukhsh! This repository is currently maintained by @farhaanbukhsh. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 94.98% 94.99% +0.01%
==========================================
Files 139 139
Lines 1356 1359 +3
Branches 265 265
==========================================
+ Hits 1288 1291 +3
Misses 60 60
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Co-authored-by: lkatsikaris <lkatsikaris@@users.noreply.github.com> Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
ca61729
to
b063153
Compare
@bradenmacdonald @arbrandes Can you folks review this PR, please 😇 |
@farhaanbukhsh Can you please provide test instructions, or get another reviewer to confirm that this is working? I don't even know how to access the gradebook, but am happy to help review if you provide the instructions (or a sandbox). |
Based on: #402