Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint to v8.x #249

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Conversation

BilalQamar95
Copy link
Contributor

Ticket
42: Upgrade eslint to v8.x

Description:

  • Upgraded eslint to v8.18 along with @edx/eslint-config, @babel/eslint-parser, @babel/core & @babel/preset-react
  • Resolved linting issues post upgrade.

@BilalQamar95 BilalQamar95 self-assigned this Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #249 (39d4374) into master (e1c3a8d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   67.13%   67.13%           
=======================================
  Files          42       42           
  Lines         782      782           
  Branches      154      154           
=======================================
  Hits          525      525           
  Misses        249      249           
  Partials        8        8           
Impacted Files Coverage Δ
...omponents/course-enrollments/CourseEnrollments.jsx 80.43% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c3a8d...39d4374. Read the comment docs.

@BilalQamar95 BilalQamar95 requested a review from a team June 24, 2022 08:19
Copy link

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me - I think we should just double-check with the owning team since frontend-app-learner-portal-programs is a pretty non-standard MFE.

@ashultz0 ashultz0 merged commit 8ad2cc4 into master Jul 25, 2022
@ashultz0 ashultz0 deleted the bilalqamar95/fed-bom-eslint-upgrade branch July 25, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants