Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'npm ci' instead of 'npm install' #251

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jun 30, 2022

Ticket
use 'npm ci' instead of 'npm install' for frontend builds

Description:
Used 'npm ci' instead of 'npm install' to install dependencies

@BilalQamar95 BilalQamar95 self-assigned this Jun 30, 2022
@BilalQamar95 BilalQamar95 requested a review from a team July 6, 2022 09:40
@BilalQamar95 BilalQamar95 added the blocked by other work PR cannot be finished until other work is complete label Jul 6, 2022
@BilalQamar95
Copy link
Contributor Author

npm ci issue will be resolved once Upgrade eslint to v8 PR is merged

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #251 (82ca479) into master (6f265b8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   67.13%   67.13%           
=======================================
  Files          42       42           
  Lines         782      782           
  Branches      154      154           
=======================================
  Hits          525      525           
  Misses        249      249           
  Partials        8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BilalQamar95 BilalQamar95 removed the blocked by other work PR cannot be finished until other work is complete label Aug 16, 2022
@abdullahwaheed abdullahwaheed merged commit cab5bd5 into master Jun 1, 2023
@abdullahwaheed abdullahwaheed deleted the bilalqamar95/workflow-dependancy-update branch June 1, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants