-
Notifications
You must be signed in to change notification settings - Fork 295
feat: support design tokens and paragon 23 #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support design tokens and paragon 23 #1588
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
c51133f to
80ea053
Compare
|
Nice, thanks! Let me know when this is ready for review. |
80ea053 to
77b9712
Compare
bc40e90 to
66f4505
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-design-tokens #1588 +/- ##
========================================================
+ Coverage 90.38% 90.41% +0.02%
========================================================
Files 341 343 +2
Lines 5752 5778 +26
Branches 1345 1386 +41
========================================================
+ Hits 5199 5224 +25
+ Misses 536 535 -1
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
96499bf to
490dcdf
Compare
|
Sandbox deployment failed 💥 |
490dcdf to
631f420
Compare
|
Sandbox deployment failed 💥 |
631f420 to
464b438
Compare
|
Sandbox deployment failed 💥 |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking wonderful!
I left a couple comments that tie into discussions on other PRs, but once we have some context on those this should be ready to merge!
src/courseware/course/sidebar/sidebars/course-outline/CourseOutlineTray.scss
Show resolved
Hide resolved
src/courseware/course/sidebar/sidebars/course-outline/CourseOutlineTray.scss
Show resolved
Hide resolved
464b438 to
f5ec395
Compare
f5ec395 to
0a7c925
Compare
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this has been a long review process, so thank you so much for your patience!
Just the one last thing about the celebration modal button and this will be ready to merge!
|
Sandbox deployment failed 💥 |
|
closing and re-opening to try to kick off CI |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this! Super excited to land it!
84d5ae9
into
openedx:master-design-tokens
Warning
This PR should not be merge to
masterdirectly, it should point tomaster-design-tokensonce the branch has been created.Description
This PR updates frontend app learning to support CSS variables and the corresponding paragon design tokens.
Changes implemented
Important
This PR requires a compatible version with paragon 23 of dependencies because of that the following PRs need to be merged first: