Deprecate react-unit-test-utils 2/2 #1751

diana-villalvazo-wgu · 2025-07-04T23:24:52Z

Description

Remove use of 'useKeyedState' (react-unit-test-utils) in following components/files:

src/courseware/course/sequence/Unit/hooks/useModalIFrameData.js
src/courseware/course/sequence/Unit/hooks/useShouldDisplayHonorCode.js
src/courseware/course/sequence/Unit/hooks/useIFrameBehavior.js

Remove use of 'StrictDict' (react-unit-test-utils) in following components/files:

src/courseware/course/sequence/Unit/hooks/useModalIFrameData.js
src/courseware/course/sequence/Unit/hooks/useShouldDisplayHonorCode.js
src/courseware/course/sequence/Unit/hooks/useIFrameBehavior.js

Remove use of 'mockUseKeyedState' (react-unit-test-utils) in following components/files:

src/courseware/course/sequence/Unit/hooks/useModalIFrameData.test.js
src/courseware/course/sequence/Unit/hooks/useShouldDisplayHonorCode.test.js
src/courseware/course/sequence/Unit/hooks/useIFrameBehavior.test.js

Remove use of 'getEffects' (react-unit-test-utils) in following components/files:

src/courseware/course/sequence/Unit/hooks/useShouldDisplayHonorCode.test.js
src/courseware/course/sequence/Unit/hooks/useIFrameBehavior.test.js

Support Information

Closes #1749

openedx-webhooks · 2025-07-04T23:24:56Z

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-07-07T14:44:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (06902d8) to head (c451fbe).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1751      +/-   ##
==========================================
+ Coverage   90.33%   90.36%   +0.02%     
==========================================
  Files         344      344              
  Lines        5793     5811      +18     
  Branches     1394     1393       -1     
==========================================
+ Hits         5233     5251      +18     
  Misses        541      541              
  Partials       19       19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vmnavarro94

LGTM 💯

brian-smith-tcril

Overall this looks great!

Left one small comment with a question but nothing major.

Thanks for this PR!

brian-smith-tcril · 2025-07-28T13:52:06Z

src/courseware/course/sequence/Unit/hooks/useIFrameBehavior.test.js

+        const customHeight = 23;
        const resizeMessage = (height = 23) => ({


I'm not quite sure what's going on with customHeight here. The default values for height in resizeMessage and testSetIFrameHeight are also set to 23, so when customHeight is used in the resizeMessage(customHeight) call down in "sets iframe height with payload height" it's the same as just calling resizeMessage().

right i wasn't clear what we are testing here, i changed the values to make it clearer 👍

brian-smith-tcril

LGTM!

commit 1d5484f Author: Jansen Kantor <jkantor@edx.org> Date: Tue Oct 28 11:12:33 2025 -0400 fix: re-add removed import (openedx#1815) commit 52692dc Author: Muhammad Anas <88967643+Anas12091101@users.noreply.github.com> Date: Fri Oct 24 22:55:12 2025 +0500 refactor: shift grade summary calculation to backend and display "hidden grades" label in the grade table (openedx#1797) Refactors the grade summary logic to delegate all calculation responsibilities to the backend. Previously, the frontend was performing grade summary computations using data fetched from the API. Now, the API itself provides the fully computed grade summary, simplifying the frontend and ensuring consistent results across clients. Additionally, a "Hidden Grades" label has been added in the grade summary table to clearly indicate sections where grades are not visible to learners. Finally, for visibility settings that depend on the due date, this PR adds a banner on the Progress page indicating that grades are not yet released, along with the relevant due date information. commit f91af21 Author: Jansen Kantor <jkantor@edx.org> Date: Mon Oct 20 12:03:07 2025 -0400 feat: add plugin slot for content iframe error component (openedx#1771) * feat: add plugin slot for content iframe error component * style: quality * fix: copilot suggestions commit 7318fb3 Author: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Date: Sun Oct 19 20:41:43 2025 -0400 chore: update browserslist DB (openedx#1808) Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com> commit 7233f08 Author: Michael Roytman <mroytman@2u.com> Date: Wed Oct 15 13:35:20 2025 -0400 feat: update version of frontend-lib-learning-assistant to 2.23.1 (openedx#1807) This commit installs version 2.23.1 of @edx/frontend-lib-learning-assistant. This release fixes a bug where the Xpert Learning Assistant was only available to learners in the audit and credit modes. See https://github.com/edx/frontend-lib-learning-assistant/releases/tag/v2.23.1. commit d6d229f Author: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Date: Sun Oct 12 20:40:36 2025 -0400 chore: update browserslist DB (openedx#1799) Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com> commit 47b9a43 Author: Muhammad Anas <88967643+Anas12091101@users.noreply.github.com> Date: Wed Oct 8 18:48:07 2025 +0500 chore: bump frontend-component-header to v8.x.x (openedx#1791) * chore: bump frontend-component-header to v6.6.x * chore: bump frontend-component-header to ^8.0.0 commit e556d5b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Oct 7 19:17:29 2025 +0000 chore(deps): update dependency @edx/frontend-component-header to v6.4.2 (openedx#1804) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 694d95a Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Oct 7 16:13:33 2025 +0000 chore(deps): update dependency @edx/frontend-component-footer to v14.9.2 (openedx#1803) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit e83813d Author: PKulkoRaccoonGang <peter.kulko@raccoongang.com> Date: Mon Oct 6 09:00:26 2025 +0300 build: Upgrade to node 24 and update package-lock.json commit a54a1b8 Author: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Date: Sun Sep 28 20:39:45 2025 -0400 chore: update browserslist DB (openedx#1795) Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com> commit d3188ef Author: Feanil Patel <feanil@axim.org> Date: Tue Sep 23 13:52:53 2025 -0400 build: remove unused @edx/reactifex package Remove @edx/reactifex package from devDependencies as it is no longer needed. Translation extraction functionality has been verified to work correctly without this dependency. Co-Authored-By: Claude <noreply@anthropic.com> commit 33f7375 Author: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Date: Sun Sep 21 20:41:28 2025 -0400 chore: update browserslist DB (openedx#1793) Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com> commit 8702630 Author: Agrendalath <piotr@surowiec.it> Date: Sat Apr 5 18:09:46 2025 +0200 fix: ensure iframe visibility tracking is triggered on load The previous implementation had a race condition that sometimes prevented XBlocks from being marked as viewed. Users had to scroll or resize the window to trigger visibility tracking instead of having it happen once content loads. commit af50d5a Author: Peter Kulko <93188219+PKulkoRaccoonGang@users.noreply.github.com> Date: Tue Sep 16 17:55:28 2025 +0300 test: Add Node 24 to CI matrix (openedx#1752) commit 7fccf77 Author: Samuel Allan <samuel@opencraft.com> Date: Mon Sep 1 14:41:52 2025 +0930 fix: update frontend-build to fix install issues Earlier versions of @openedx/frontend-build used on older version of 'sharp', which caused intermittent installation issues. The version of 'sharp' was updated in @openedx/frontend-build to fix these issues, so the frontend-build version can be updated here, to fix the issues in this project too. See openedx/frontend-build#664 and openedx/frontend-build#665 for more information. The frontend-build dependency was updated by: ``` npm install --package-lock-only @openedx/frontend-build ``` Private-ref: https://tasks.opencraft.com/browse/BB-9953 commit c760bc4 Author: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Date: Sun Sep 7 20:40:25 2025 -0400 chore: update browserslist DB (openedx#1788) Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com> commit d5140a6 Author: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Date: Sun Aug 31 20:46:51 2025 -0400 chore: update browserslist DB (openedx#1784) Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com> commit 9bf5d01 Author: Isaac Lee <124631592+ilee2u@users.noreply.github.com> Date: Mon Aug 25 12:54:13 2025 -0400 chore: update learning assistant plugin 2.23.0 (openedx#1781) commit f333408 Author: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Date: Sun Aug 24 20:41:09 2025 -0400 chore: update browserslist DB (openedx#1783) Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com> commit 4840fff Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Aug 21 14:21:56 2025 -0700 chore(deps): bump actions/download-artifact from 4 to 5 (openedx#1779) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 579bd03 Author: Muhammad Adeel Tajamul <77053848+muhammadadeeltajamul@users.noreply.github.com> Date: Thu Aug 21 23:09:28 2025 +0500 feat: updated notification preferences unsubscribe flow (openedx#1778) commit 2b4a966 Author: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com> Date: Mon Aug 18 00:39:50 2025 +0000 chore: update browserslist DB commit a6e4e28 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Aug 11 22:15:57 2025 +0000 chore(deps): bump actions/checkout from 4 to 5 Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> commit e6f7588 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Aug 5 20:30:19 2025 +0000 chore(deps): bump js-toml from 1.0.1 to 1.0.2 Bumps [js-toml](https://github.com/sunnyadn/js-toml) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/sunnyadn/js-toml/releases) - [Commits](sunnyadn/js-toml@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: js-toml dependency-version: 1.0.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> commit db29e31 Author: Muhammad Anas <88967643+Anas12091101@users.noreply.github.com> Date: Mon Aug 4 19:36:44 2025 +0500 feat: customize proctoring review requirements link using externalLinkUrlOverrides (openedx#1775) commit e9121f9 Author: Diana Olarte <diana.olarte@edunext.co> Date: Mon May 26 15:39:18 2025 +1000 feat: display the certificate available date if available in progress tab commit 9cbc227 Author: Nawfal Ahmed <111358247+NawfalAhmed@users.noreply.github.com> Date: Thu Jul 31 23:53:18 2025 +0500 feat: use discount info endpoint for streak discount information (openedx#1763) * feat: use discount info endpoint for streak discount information * feat: pass course run key to discount code info call * feat: move changes behind a flag * fix: use async IIFE inside useEffect * fix: fix line length * fix: remove default value in dev * fix: improve coverage by adding conditional test based on env value * refactor: move logic inside function * refactor: move functions to utils * fix: ignore merge config commit 4c8aa7c Author: Maniraja Raman <mraman-apphelix@2u.com> Date: Wed Jul 30 02:18:07 2025 +0530 feat: add FEATURE_ENABLE_CHAT_V2_ENDPOINT to environment files and update library version (openedx#1768) commit 6892633 Author: Diana Villalvazo <diana.villalvazo@wgu.edu> Date: Tue Jul 29 08:13:07 2025 -0600 test: transform snapshot into rtl test 1/2 (openedx#1756) * test: remove snapshots and use rtl tests * test: improve coverage on search results test commit 56a73ee Author: Diana Villalvazo <diana.villalvazo@wgu.edu> Date: Tue Jul 29 08:03:07 2025 -0600 test: transform snapshot into rtl test 2/2 (openedx#1757) * test: remove snapshots and use rtl tests * test: add expected result on map search commit bf95916 Author: Jacobo Dominguez <jacobo.dominguez@wgu.edu> Date: Mon Jul 28 12:10:49 2025 -0600 docs: add comprehensive readme documentation for plugin slots (openedx#1770) commit 48270c3 Author: Diana Villalvazo <diana.villalvazo@wgu.edu> Date: Mon Jul 28 12:02:55 2025 -0600 chore: remove react-unit-test-utils package (openedx#1758) commit 33d7d66 Author: Diana Villalvazo <diana.villalvazo@wgu.edu> Date: Mon Jul 28 10:48:53 2025 -0600 test: deprecate react-unit-test-utils 1/2 (openedx#1750) commit a75c89c Author: Diana Villalvazo <diana.villalvazo@wgu.edu> Date: Mon Jul 28 10:12:32 2025 -0600 test: deprecate react-test-utils 2/2 (openedx#1751) commit 06902d8 Author: Ihor Romaniuk <ihor.romaniuk@raccoongang.com> Date: Mon Jul 21 20:57:43 2025 +0200 feat: remove waffle flags for managing course outline sidebar (openedx#1713) * feat: remove waffle flags for managing course outline sidebar * fix: flag and tests * fix: product-tours tests * fix: remove default content for SequenceNavigationSlot and update tests * fix: remove default content for CourseBreadcrumbsSlot * fix: update plugin-slots version and documentation * revert: update plugin-slots version * fix: update tests commit e413464 Author: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Date: Sun Jul 6 20:44:46 2025 -0400 chore: update browserslist DB (openedx#1755) Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com> commit 77fcc83 Author: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Date: Sun Jun 29 20:43:50 2025 -0400 chore: update browserslist DB (openedx#1744) Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com> commit b050535 Author: Farhaan Bukhsh <farhaan@opencraft.com> Date: Tue Jul 30 00:57:46 2024 +0530 fix: Fixes the auto_advance feature for video XBlock The commit adds eventlistener which picks up the autoAdvance message and triggers the next sequence. This has the same effect of clicking the next button. Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com> commit ddbc212 Author: Brian Smith <112954497+brian-smith-tcril@users.noreply.github.com> Date: Wed Jun 18 12:07:01 2025 -0400 feat!: add design tokens support (openedx#1737) BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <diana.olarte@edunext.co> commit 462e75f Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jun 18 14:03:53 2025 +0000 fix(deps): update dependency @edx/frontend-platform to v8.4.0 (openedx#1739) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit bc4c8c2 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jun 18 05:29:53 2025 +0000 fix(deps): update dependency @edx/frontend-component-footer to v14.9.0 (openedx#1736) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit ecd5164 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jun 18 01:03:51 2025 +0000 fix(deps): update dependency @openedx/frontend-build to v14.6.1 (openedx#1700) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 44d952b Author: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Date: Sun Jun 15 20:42:49 2025 -0400 chore: update browserslist DB (openedx#1734) Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 4, 2025

openedx-webhooks added this to Contributions Jul 4, 2025

github-project-automation bot moved this to Needs Triage in Contributions Jul 4, 2025

diana-villalvazo-wgu force-pushed the 1749/depr2of2 branch from 9765cc5 to 3eb9fa3 Compare July 7, 2025 14:39

diana-villalvazo-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Jul 7, 2025

diana-villalvazo-wgu moved this from Needs Triage to Ready for Review in Contributions Jul 7, 2025

vmnavarro94 approved these changes Jul 7, 2025

View reviewed changes

diana-villalvazo-wgu requested a review from farhaanbukhsh July 8, 2025 15:26

diana-villalvazo-wgu mentioned this pull request Jul 8, 2025

Deprecate react-unit-test-utils package #1758

Merged

diana-villalvazo-wgu requested a review from a team July 21, 2025 21:45

brian-smith-tcril reviewed Jul 28, 2025

View reviewed changes

diana-villalvazo-wgu added 2 commits July 28, 2025 09:43

test: deprecate react-test-utils

f64f614

chore: lint fixes

8aa7162

diana-villalvazo-wgu force-pushed the 1749/depr2of2 branch from 3eb9fa3 to 1e47ec7 Compare July 28, 2025 15:50

test: diff customheight to test

c451fbe

diana-villalvazo-wgu force-pushed the 1749/depr2of2 branch from 1e47ec7 to c451fbe Compare July 28, 2025 15:54

brian-smith-tcril approved these changes Jul 28, 2025

View reviewed changes

brian-smith-tcril merged commit a75c89c into openedx:master Jul 28, 2025
7 checks passed

github-project-automation bot moved this from Ready for Review to Done in Contributions Jul 28, 2025

diana-villalvazo-wgu deleted the 1749/depr2of2 branch July 28, 2025 16:17

nsprenkle pushed a commit to edx/frontend-app-learning that referenced this pull request Dec 23, 2025

test: deprecate react-test-utils 2/2 (openedx#1751)

e5391de

nsprenkle pushed a commit to edx/frontend-app-learning that referenced this pull request Dec 23, 2025

test: deprecate react-test-utils 2/2 (openedx#1751)

1f38447

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Deprecate react-unit-test-utils 2/2 #1751

Deprecate react-unit-test-utils 2/2 #1751

Uh oh!

diana-villalvazo-wgu commented Jul 4, 2025

Uh oh!

openedx-webhooks commented Jul 4, 2025

Uh oh!

codecov bot commented Jul 7, 2025 •

edited

Loading

Uh oh!

vmnavarro94 left a comment

Uh oh!

brian-smith-tcril left a comment

Uh oh!

brian-smith-tcril Jul 28, 2025

Uh oh!

diana-villalvazo-wgu Jul 28, 2025 •

edited

Loading

Uh oh!

brian-smith-tcril left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		const customHeight = 23;
		const resizeMessage = (height = 23) => ({

Deprecate react-unit-test-utils 2/2 #1751

Deprecate react-unit-test-utils 2/2 #1751

Uh oh!

Conversation

diana-villalvazo-wgu commented Jul 4, 2025

Description

Support Information

Uh oh!

openedx-webhooks commented Jul 4, 2025

Uh oh!

codecov bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vmnavarro94 left a comment

Choose a reason for hiding this comment

Uh oh!

brian-smith-tcril left a comment

Choose a reason for hiding this comment

Uh oh!

brian-smith-tcril Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

diana-villalvazo-wgu Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brian-smith-tcril left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jul 7, 2025 •

edited

Loading

diana-villalvazo-wgu Jul 28, 2025 •

edited

Loading