Skip to content

fix: rewrite calcualtor tips to reflect the supported features#825

Merged
jmyatt merged 1 commit intoopenedx:masterfrom
ghassanmas:fix-820
Feb 17, 2022
Merged

fix: rewrite calcualtor tips to reflect the supported features#825
jmyatt merged 1 commit intoopenedx:masterfrom
ghassanmas:fix-820

Conversation

@ghassanmas
Copy link
Member

Fixes #820

  • Removing constants that are no longer supported
  • Removing suffixes that are no longer supported

@pdpinch Following our conversation, here is the PR.

  Fixes openedx#820
  - Removing constants that are no longer supported
  - Removing suffixes that are no longer supported
@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Feb 15, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas! I've created OSPR-6457 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene
Copy link

@ghassanmas Thank you for your contribution. Please let me know once this is ready for our review.

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Feb 16, 2022
@ghassanmas
Copy link
Member Author

ghassanmas commented Feb 16, 2022 via email

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #825 (61baccd) into master (7b6f5cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   83.75%   83.75%           
=======================================
  Files         253      253           
  Lines        4415     4415           
  Branches     1114     1114           
=======================================
  Hits         3698     3698           
  Misses        697      697           
  Partials       20       20           
Impacted Files Coverage Δ
...are/course/content-tools/calculator/Calculator.jsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b6f5cc...61baccd. Read the comment docs.

@openedx-webhooks openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Feb 16, 2022
Copy link

@jmyatt jmyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmyatt jmyatt merged commit 616027d into openedx:master Feb 17, 2022
@openedx-webhooks
Copy link

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite calculator supported constants

4 participants