fix: rewrite calcualtor tips to reflect the supported features#29957
fix: rewrite calcualtor tips to reflect the supported features#29957rgraber merged 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @ghassanmas! I've created OSPR-6481 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
This ready for review also this #29080 as well |
|
Hi there @ghassanmas! Can you add testing instructions to your cover letter? That would be helpful for others! 😄 |
|
@mariajgrimaldi Just did wrote detailed instructions to test and provided more context as well. Let me know if you have any questions. |
|
@ghassanmas Thank you for the contribution. I will line this up for our review. |
|
@ghassanmas it seems like quality checks are failing, please resolve and then I can rereview |
- It replicate this PR: frontend-app-learning/pull/825 which rewrite calcualtor tips since some tips are no longer relevant, hence: openedx#17368
3f6bd25 to
85a3b2f
Compare
|
@rgraber I did ran the |
I'll take a look once tests run again |
|
Apparently there is a known issue with this test. We are going to disable it since it's not really that valuable anymore. at that point i'll rerun the tests on this guy and hopefully that will be enough |
|
Alright, in other words the tests needs tests 😅 |
|
@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description and Related information
It replicates this PR: openedx/frontend-app-learning/pull/825 which
rewrite calcualtor tips since some tips are no longer relevant,
hence: #17368
Testing:
To be to test this change, here are the steps:
Show Calcutratortotrue, follow this doc link for more detailsibutton the calculator instructions tips, should reflect the change of this PR. e.g., there should be no example of using T as constant...etc.** You would need to make sure that you are interacting with the course through the old course experience, not using the learning MFE hence, it's already resolved for the learning MFE openedx/frontend-app-learning/pull/825.
Relative information about how enable use old courseware experience: