-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove duplicate language in onboarding instructions #144
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me, but I have a concern about the ID.
Because we're removing the string with the ID
exam.SubmittedProctoredExamInstructions.text5, I looked around for where it's used and where the string with IDexam.SubmittedProctoredExamInstructions.text1is used, because it'll be the ID of the string on the page. I noticed thatexam.SubmittedProctoredExamInstructions.text1is used to identify two unique strings in this library. I'm not sure what happens when two IDs are used for two different strings - how does the Open edX translations code decide which string to send to Transifex for that ID? At least in this locale, the other string is associated with this ID. I think it would be safer to keep this string with the IDexam.SubmittedProctoredExamInstructions.text5because it's unique. Do you see any issues with keeping this ID instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that makes a lot of sense! I will change this back to using
exam.SubmittedProctoredExamInstructions.text5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry. I swore this string had ID
text5before, but now it'stext4🫨. I think the string that we are keeping (which has IDtext1above) should havetext4.text1is associated with two different strings currently, so if we switch totext4, then onlytext4will be associated with this string, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you're saying! Sorry I didn't catch that before. I will update the ID for
text1to betext4