-
Notifications
You must be signed in to change notification settings - Fork 5
[FC-0099] fix: update permissions for role list view #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC-0099] fix: update permissions for role list view #105
Conversation
|
Thanks for the pull request, @BryanttV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BryanttV.
This is align with the https://openedx-authz.readthedocs.io/en/latest/concepts/core_roles_and_permissions/content_library_roles.html
|
I'll add this change to the changelog for the next version. |
Description
The get roles by scope endpoint should require the
view_library_teampermission instead ofmanage_library_team, since all library roles (library_admin,library_author,library_collaborator, andlibrary_user) should have permission to view the roles and their associated permissions.Supporting Information
Testing Instructions
Using Tutor:
tutor dev exec lms python manage.py lms migratetutor dev exec lms python manage.py lms load_policies/api/authz/v1/roles/?scope={library-id}endpoint with users with different roles (library_admin,library_author,library_collaborator, andlibrary_user)Merge Checklist
Check off if complete or not applicable: