Skip to content

Conversation

@MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Oct 10, 2025

Description

This PR adds the default authz.policy and a flag in the load_policies to remove the previous ones.

Documentation: https://openedx-authz.readthedocs.io/en/latest/concepts/core_roles_and_permissions/content_library_roles.html

Related wiki page: https://openedx.atlassian.net/wiki/spaces/OEPM/pages/4840095745/Library+Roles+and+Permissions

How to test

The easiest way is with the rest api. I added these commits over the #84 in here: https://github.com/eduNEXT/openedx-authz/tree/mfmz/test-authz, so you can:

Checklist

Merge checklist:
Check off if complete or not applicable:

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 10, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 10, 2025

Thanks for the pull request, @MaferMazu!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 10, 2025
@MaferMazu MaferMazu changed the title Mfmz/default policy Mfmz/default policy (for test, no merge) Oct 10, 2025
@MaferMazu MaferMazu force-pushed the mfmz/default-policy branch 3 times, most recently from a1ea4e2 to f810748 Compare October 13, 2025 19:32
@MaferMazu MaferMazu changed the title Mfmz/default policy (for test, no merge) [FC-0099] feat: add default policy and fix tests Oct 13, 2025
@MaferMazu MaferMazu force-pushed the mfmz/default-policy branch 2 times, most recently from 7e7c189 to 688fa60 Compare October 13, 2025 20:37
@MaferMazu MaferMazu marked this pull request as ready for review October 13, 2025 21:09
@MaferMazu MaferMazu linked an issue Oct 13, 2025 that may be closed by this pull request
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaferMazu! Please rebase this branch with main.

@MaferMazu
Copy link
Contributor Author

@mariajgrimaldi @bmtcril @BryanttV, this is ready for re-review. Thanks for your patience.

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't compared the authz.policy changes against the docs, but otherwise LGTM

Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the permissions for each role and tested the command. Everything works correctly. Thank you, @MaferMazu!

@MaferMazu
Copy link
Contributor Author

MaferMazu commented Oct 21, 2025

Note for me: Add to the changelog #105 and #107

Done ✅

@MaferMazu MaferMazu force-pushed the mfmz/default-policy branch from d59f355 to c964c18 Compare October 21, 2025 23:11
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't go into too much detail about the policy, but the rest looks good to go. Thank you!

@mariajgrimaldi mariajgrimaldi merged commit c911424 into openedx:main Oct 22, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Default policies and configuration

6 participants