-
Notifications
You must be signed in to change notification settings - Fork 5
[FC-0099] feat: add default policy and fix tests #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @MaferMazu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
a1ea4e2 to
f810748
Compare
7e7c189 to
688fa60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MaferMazu! Please rebase this branch with main.
00c691c to
68776e0
Compare
68776e0 to
10a0066
Compare
a8fb2d8 to
6bc3b1c
Compare
|
@mariajgrimaldi @bmtcril @BryanttV, this is ready for re-review. Thanks for your patience. |
bmtcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't compared the authz.policy changes against the docs, but otherwise LGTM
BryanttV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the permissions for each role and tested the command. Everything works correctly. Thank you, @MaferMazu!
d59f355 to
c964c18
Compare
mariajgrimaldi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't go into too much detail about the policy, but the rest looks good to go. Thank you!
Description
This PR adds the default authz.policy and a flag in the load_policies to remove the previous ones.
Documentation: https://openedx-authz.readthedocs.io/en/latest/concepts/core_roles_and_permissions/content_library_roles.html
Related wiki page: https://openedx.atlassian.net/wiki/spaces/OEPM/pages/4840095745/Library+Roles+and+Permissions
How to test
The easiest way is with the rest api. I added these commits over the #84 in here: https://github.com/eduNEXT/openedx-authz/tree/mfmz/test-authz, so you can:
python manage.py lms load_policies --clear-existingChecklist
Merge checklist:
Check off if complete or not applicable: