Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add missing configuration for testing #3

Merged
merged 1 commit into from
May 4, 2021
Merged

test: add missing configuration for testing #3

merged 1 commit into from
May 4, 2021

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented May 4, 2021 •
edited
Loading

Description:

This PR adds the necessary configuration to run unittesting using django settings.

Testing instructions:

  1. PR feat: add Hooks Extension Framework tooling for filters #2 #1 uses this configuration to run tests

Reviewers:

morenol
morenol approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, after a squash. Maybe we should use test: or ci: for the description of the squashed commit

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/fix_tests_config branch from 30c2d1e to 82cc9ab Compare May 4, 2021 18:47
@mariajgrimaldi mariajgrimaldi changed the title fix: add missing configuration for testing test: add missing configuration for testing May 4, 2021
@mariajgrimaldi mariajgrimaldi merged commit c810978 into main May 4, 2021
@mariajgrimaldi mariajgrimaldi deleted the MJG/fix_tests_config branch May 7, 2021 13:34
@mariajgrimaldi mariajgrimaldi mentioned this pull request Jun 8, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morenol morenol morenol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariajgrimaldi @morenol