-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Hooks Extension Framework tooling for filters #2 #1
Conversation
eee2953
to
598576f
Compare
d823ba4
to
d6ea886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I added a couple of comments
4b13e22
to
e0f1c15
Compare
30c2d1e
to
82cc9ab
Compare
47afaec
to
b415432
Compare
b415432
to
b53c1f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with different filter definitions, different pipeline configurations and different logic for raising exceptions and it performed as we have so long discussed via all the channels.
Thanks @mariajgrimaldi, I think we are ready to merge
Please squash the 10 commits before merging |
This PR adds the tooling needed to execute filters, a pipeline deeply inspired in the TPA Pipeline from social core project.
a3109ed
to
0a7164b
Compare
Description:
This PR adds the tooling needed by the Hooks Extension Framework to execute filters. This project is described in more depth in the OEP-50.
The tooling consists of a pipeline (Pipeline tooling ADR) that executes a list of functions pre-configured that are associated with the filter via Django settings (Filters configuration ADR).
Dependencies:
The architectural design records where the configuration and pipeline design used by the tooling are defined in Pull Request #2.
Testing instructions:
make lms-shell
pip install -e git+https://github.com/eduNEXT/openedx-filters.git@MJG/filter_tooling#egg=filter_tooling
pip install -e https://github.com/eduNEXT/openedx-basic-hooks.git
, you can also use your own test library. Here are defined the functions that will be executed by a trigger.Year of birth
add 2020 (or any year after 2000).Reviewers:
Merge checklist:
Post merge:
finished.