Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add filters implementation P1 #4

Closed
wants to merge 13 commits into from

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented May 5, 2021

Description:
This PR adds filters for the following processes:

  • Login
  • Registration
  • Enrollment
  • Un-enrollment

Dependencies:
The implementation uses the tooling defined in #1

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns:

  • Folder structure, is this what we want? : from openedx_filters.lms.auth.v1.login import before_creation as pre_login_filter
  • Filter naming: before_creation? we'd have to always import like this: from ... import before_creation as CONTEXT_NAME

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/filters_signatures branch from f41a8b1 to 6821412 Compare May 5, 2021 15:34
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/filters_signatures branch from 8790baf to 358d6dc Compare May 7, 2021 13:37
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/filters_signatures branch 3 times, most recently from 0796d63 to e9e9a89 Compare May 7, 2021 15:36
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/filters_signatures branch from e9e9a89 to 1bf4d4e Compare May 7, 2021 15:37
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review May 7, 2021 19:00
@mariajgrimaldi mariajgrimaldi changed the title feat: add filters implementation P1 [WIP] feat: add filters implementation P1 May 7, 2021
@mariajgrimaldi
Copy link
Member Author

any comments so far? @felipemontoya

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/filters_signatures branch from b5af07a to 9c2e9d3 Compare May 7, 2021 19:10
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/filters_signatures branch from 9c2e9d3 to b18f6df Compare May 7, 2021 19:28
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/filters_signatures branch from 3e6004e to 7893e88 Compare May 12, 2021 22:36
@mariajgrimaldi mariajgrimaldi deleted the MJG/filters_signatures branch March 28, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant