Skip to content

Conversation

@bradenmacdonald
Copy link
Contributor

  • The import code that accepts a file object should have type BinaryIO (any file-like object that produces bytes), not BytesIO (specifically an in-memory bytes object and not a file handle)
  • As I experienced, if a TypeError occurred during import (e.g. because you forgot to open the CSV file as binary instead of as a string...) then the import task would become permanently stuck because TypeError exceptions were not caught.

No need for a version bump with this fix.

Private ref: can be considered part of FAL-3531.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 21, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this by running this branch in my devstack and testing importing a taxonomy CSVs and JSONs
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@bradenmacdonald bradenmacdonald merged commit 30260cb into main Nov 21, 2023
@bradenmacdonald bradenmacdonald deleted the braden/minor-import-fix branch November 21, 2023 17:35
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants