Skip to content

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Nov 21, 2023

WIP

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 21, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

taxonomy.delete()
return Response(import_error, status=status.HTTP_400_BAD_REQUEST)
except ValueError as e:
taxonomy.delete()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido I think this issue was addressed by the recently-merged #122 -- it changed the import code to catch generic Exceptions, so we should never see the ValueError here.

We didn't tag a new release with that fix though, so will need to wait until a new release is tagged to run it with the platform.

@rpenido rpenido force-pushed the rpenido/fal-3536-fix-import-plan-bug branch 2 times, most recently from 40e41f4 to 1d418d6 Compare November 22, 2023 16:51
@rpenido rpenido changed the title fix: fix bug in taxonomy import plan fix: bug in taxonomy import plan Nov 22, 2023
@rpenido rpenido force-pushed the rpenido/fal-3536-fix-import-plan-bug branch from 1d418d6 to 3080ac3 Compare November 22, 2023 18:57
@rpenido rpenido closed this Nov 30, 2023
@rpenido rpenido deleted the rpenido/fal-3536-fix-import-plan-bug branch November 30, 2023 21:38
@openedx-webhooks
Copy link

@rpenido Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@rpenido
Copy link
Contributor Author

rpenido commented Dec 1, 2023

Closed in favor of #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants