-
Notifications
You must be signed in to change notification settings - Fork 18
fix: skip parent update from deleted tags #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip parent update from deleted tags #126
Conversation
|
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
956958d to
140fb6c
Compare
140fb6c to
dace8b8
Compare
2ad5ec4 to
537c6a0
Compare
537c6a0 to
5eef869
Compare
ChrisChV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido 👍
- I tested this: I verified the code and tests
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes tests for bugfixes and/or features added.
Use WIP branch from openedx/openedx-learning#126
|
Merging now. I see there's no version bump - let me know if we need to add one at some point, or just wait to combine this with other changes. |
|
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR prevents creating an
UpdateParentaction associated with a Tag that will be deleted.Example:
Actions before PR:
Actions after PR:
It also checks if the Tag actually exists in the database before executing the
Deleteaction. In the example above, because we didn't update the parent of tags 1.1 and 1.1.1, actions#2and#3should be skipped because both tags were cascade deleted on action#1.Testing instructions
Private-ref: