-
Notifications
You must be signed in to change notification settings - Fork 18
feat: get or create static files for each component version in lp_dump file #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get or create static files for each component version in lp_dump file #370
Conversation
|
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
d547870 to
fccbf50
Compare
ormsbee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor request, and then please squash your commits and I'll merge.
…p zip Ensure each component version includes its corresponding static files, generated or retrieved, whether they come from virtual or physical content.
3f2e59a to
a305bee
Compare
Description
Resolves: #359
This draft PR introduces support for retrieving static files for each component version, ensuring they are correctly generated or fetched when building the
lp_dumpzip file.Summary
prefetch_relatedto the content model queries to avoid N+1 issues, along with its corresponding test