add check transcript ajax for edx_video_id #17938

muhammad-ammar · 2018-04-12T12:37:26Z

No description provided.

edx-status-bot · 2018-04-12T13:22:10Z

Your PR has finished running tests.

edx-status-bot · 2018-04-13T07:41:45Z

Your PR has finished running tests.

edx-status-bot · 2018-04-14T09:37:23Z

Your PR has finished running tests.

edx-status-bot · 2018-04-15T06:17:42Z

Your PR has finished running tests.

edx-status-bot · 2018-04-16T12:31:20Z

Your PR has finished running tests.

edx-status-bot · 2018-04-16T14:08:28Z

Your PR has finished running tests.

edx-status-bot · 2018-04-16T22:10:19Z

Your PR has finished running tests.

edx-status-bot · 2018-04-17T13:55:06Z

Your PR has finished running tests.

edx-status-bot · 2018-04-17T14:58:44Z

Your PR has finished running tests.

muhammad-ammar · 2018-04-18T04:16:45Z

jenkins run all

edx-status-bot · 2018-04-18T05:00:50Z

Your PR has finished running tests.

edx-status-bot · 2018-04-18T13:21:11Z

Your PR has finished running tests.

edx-status-bot · 2018-04-19T13:56:53Z

Your PR has finished running tests.

edx-status-bot · 2018-04-19T14:30:54Z

Your PR has finished running tests.

edx-status-bot · 2018-04-19T15:12:46Z

Your PR has finished running tests.

muhammad-ammar · 2018-04-19T15:14:47Z

jenkins run js

edx-status-bot · 2018-04-19T15:23:44Z

Your PR has finished running tests.

edx-status-bot · 2018-04-20T08:37:35Z

Your PR has finished running tests.

edx-status-bot · 2018-04-23T14:34:42Z

Your PR has finished running tests.

edx-status-bot · 2018-04-24T12:42:28Z

Your PR has finished running tests.

muhammad-ammar · 2018-04-25T14:29:00Z

jenkins run all

edx-status-bot · 2018-04-25T15:16:57Z

Your PR has finished running tests.

edx-status-bot · 2018-04-26T04:44:45Z

Your PR has finished running tests.

muhammad-ammar · 2018-04-26T14:10:32Z

@mushtaqak This is waiting for your review

edx-status-bot · 2018-04-27T06:52:35Z

Your PR has finished running tests.

edx-status-bot · 2018-04-30T13:27:08Z

Your PR has finished running tests.

mushtaqak

Miner comments, rest is looking 👍

mushtaqak · 2018-04-27T11:03:35Z

cms/djangoapps/contentstore/views/transcripts_ajax.py


    try:
-        get_transcript_from_val(edx_video_id=item.edx_video_id, lang=u'en')
+        edx_video_id = videos.get('edx_video_id')


let's clean this.

mushtaqak · 2018-04-27T13:32:31Z

cms/static/js/views/metadata.js


+    Metadata.VideoID = Metadata.String.extend({
+        // Delay between check_transcript requests
+        requestDelay: 300,


300 should be a constant

mushtaqak · 2018-04-30T11:26:27Z

cms/static/js/spec/video/transcripts/videolist_spec.js

+            spyOn(editor, 'getLocator').and.returnValue(component_locator);
+
+            // reset
+            Backbone.trigger.calls.reset();


Why is this needed ?

Events(Backbone.trigger) were triggered when Editor view is rendered above. We are clearing the those calls so that we can test in a clean state.

mushtaqak · 2018-04-30T11:26:47Z

cms/static/js/spec/video/transcripts/videolist_spec.js

                MessageManager: MessageManager
            });
+
+            waitForEvent()


what is this doing exactly?

This waits for transcripts:basicTabFieldChanged event which was triggered when VideoList is rendered.

mushtaqak · 2018-04-30T13:31:35Z

common/lib/xmodule/xmodule/video_module/video_module.py

+        # whenever edx_video_id changes on frontend. Thats why we
+        # are changing type to `VideoID` so that a specific
+        # Backbonjs view can handle it.
+        editable_fields['edx_video_id']['type'] = 'VideoID'


mushtaqak · 2018-04-30T13:31:42Z

cms/static/js/views/video/transcripts/metadata_videolist.js

+            if (response.responseJSON !== undefined) {
+                errorMessage = response.responseJSON.status;
+            } else {
+                errorMessage = gettext('Error: Connection with server failed.');


we can remove this else block since errorMessage is declared with gettext('Error: Connection with server failed.');

mushtaqak · 2018-04-30T13:35:59Z

cms/static/js/views/video/transcripts/editor.js

+            return this.$el.closest('[data-locator]').data('locator');
+        },
+
+        handleFieldChanged: function() {


I think we may need docstring for this method or a comment at-least

muhammad-ammar · 2018-05-02T09:23:57Z

@mushtaqak Addressed feedback.

edx-status-bot · 2018-05-02T09:41:08Z

Your PR has finished running tests.

EDUCATOR-2761

EDUCATOR-2752

edx-status-bot · 2018-05-02T13:59:54Z

Your PR has finished running tests.

…ad-edx-video-id basic tab attach uploads with edx_video_id

edx-status-bot · 2018-05-03T07:08:36Z

Your PR has finished running tests.

muhammad-ammar requested a review from mushtaqak April 12, 2018 12:37

muhammad-ammar force-pushed the ammar/EDUCATOR-1759-delete-transcript-from-advance-tab branch from 6e1784f to 6784ee7 Compare April 12, 2018 19:54

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from 39411c3 to eec9b74 Compare April 13, 2018 06:56

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from eec9b74 to de95b17 Compare April 14, 2018 08:58

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from de95b17 to 7eaef32 Compare April 15, 2018 05:39

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch 2 times, most recently from 788ee72 to fe05b18 Compare April 16, 2018 13:32

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch 2 times, most recently from 6e3680c to c21461d Compare April 17, 2018 13:49

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from 0bbf6c4 to bc6b589 Compare April 19, 2018 13:29

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from bc6b589 to 6fc318b Compare April 19, 2018 14:40

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from 6fc318b to 0e16708 Compare April 20, 2018 08:00

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from e5528b7 to f6aea07 Compare April 23, 2018 13:55

muhammad-ammar force-pushed the ammar/EDUCATOR-1759-delete-transcript-from-advance-tab branch from 82d0968 to d5758bd Compare April 24, 2018 11:50

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from f6aea07 to d7b5b6b Compare April 24, 2018 11:55

muhammad-ammar changed the base branch from ammar/EDUCATOR-1759-delete-transcript-from-advance-tab to transcripts-phase-2 April 25, 2018 13:28

muhammad-ammar changed the base branch from transcripts-phase-2 to ammar/remove-video-transcript-enabled-flag April 26, 2018 03:59

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from d7b5b6b to 88c2a08 Compare April 26, 2018 04:01

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from 88c2a08 to 388649b Compare April 27, 2018 06:06

muhammad-ammar force-pushed the ammar/remove-video-transcript-enabled-flag branch from 6a8ea29 to aaaafee Compare April 30, 2018 10:59

muhammad-ammar changed the base branch from ammar/remove-video-transcript-enabled-flag to transcripts-phase-2 April 30, 2018 12:35

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from 388649b to 35611e7 Compare April 30, 2018 12:52

mushtaqak approved these changes Apr 30, 2018

View reviewed changes

add check transcript ajax for edx_video_id

c02955d

muhammad-ammar force-pushed the ammar/add-check-transcript-ajax-on-basic-tab branch from 4ce3382 to c02955d Compare May 2, 2018 13:24

muhammad-ammar added 2 commits May 2, 2018 18:25

basic tab attach uploads with edx_video_id

1c53360

EDUCATOR-2761

address review and add test

84ab9ca

EDUCATOR-2752

Merge pull request #18032 from edx/ammar/EDUCATOR-2761-basic-tab-uplo…

b456b24

…ad-edx-video-id basic tab attach uploads with edx_video_id

muhammad-ammar merged commit 583bacf into transcripts-phase-2 May 3, 2018

UmanShahzad deleted the ammar/add-check-transcript-ajax-on-basic-tab branch May 9, 2018 20:42

add check transcript ajax for edx_video_id #17938

add check transcript ajax for edx_video_id #17938

Uh oh!

Conversation

muhammad-ammar commented Apr 12, 2018

Uh oh!

edx-status-bot commented Apr 12, 2018

Uh oh!

edx-status-bot commented Apr 13, 2018

Uh oh!

edx-status-bot commented Apr 14, 2018

Uh oh!

edx-status-bot commented Apr 15, 2018

Uh oh!

edx-status-bot commented Apr 16, 2018

Uh oh!

edx-status-bot commented Apr 16, 2018

Uh oh!

edx-status-bot commented Apr 16, 2018

Uh oh!

edx-status-bot commented Apr 17, 2018

Uh oh!

edx-status-bot commented Apr 17, 2018

Uh oh!

muhammad-ammar commented Apr 18, 2018

Uh oh!

edx-status-bot commented Apr 18, 2018

Uh oh!

edx-status-bot commented Apr 18, 2018

Uh oh!

edx-status-bot commented Apr 19, 2018

Uh oh!

edx-status-bot commented Apr 19, 2018

Uh oh!

edx-status-bot commented Apr 19, 2018

Uh oh!

muhammad-ammar commented Apr 19, 2018

Uh oh!

edx-status-bot commented Apr 19, 2018

Uh oh!

edx-status-bot commented Apr 20, 2018

Uh oh!

edx-status-bot commented Apr 23, 2018

Uh oh!

edx-status-bot commented Apr 24, 2018

Uh oh!

muhammad-ammar commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 26, 2018

Uh oh!

muhammad-ammar commented Apr 26, 2018

Uh oh!

edx-status-bot commented Apr 27, 2018

Uh oh!

edx-status-bot commented Apr 30, 2018

Uh oh!

mushtaqak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muhammad-ammar commented May 2, 2018