FC-0001: Account pages -> micro-frontend by UvgenGen · Pull Request #30336 · openedx/openedx-platform

UvgenGen · 2022-05-02T14:04:17Z

Merge after the Olive release.

Description

replaced edx-platform's older implementation of the Django-server-side rendering of the following pages with new micro-frontend-based implementations:

Learner Profile page: edx/frontend-app-profile
Order History page: edx/frontend-app-ecommerce
Account pages: edx/frontend-app-account
** Account Settings

PR to frontend-platform: openedx/frontend-platform#326
PR to frontend-component-header: openedx/frontend-component-header#210

Supporting information

openedx/public-engineering#71
Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-17

openedx-webhooks · 2022-05-02T14:04:22Z

Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

natabene · 2022-05-03T20:25:58Z

@dianakhuang This seems to be with arch-bom, do you mind reviewing and merging?

abdullahwaheed · 2022-10-17T09:02:37Z

@UvgenGen i have reviewed and tested your changes and resolved merge conflicts locally. I cannot push my changes in your forked repo. Please either give me write access to your repo or i'll provide the patch file for changes.

UvgenGen · 2022-10-17T09:27:13Z

@abdullahwaheed Could you provide the patch file please?

abdullahwaheed · 2022-10-17T14:08:26Z

@UvgenGen the patch couldn't created for all the commits as i have merged it with master and resolved conflicts only. Could you please rebase it with master and i'll help you resolve the conflicts

UvgenGen · 2022-10-17T14:42:25Z

@abdullahwaheed yes, sure. I rebased this PR and resolved conflicts. Files affected: lms/djangoapps/discussion/views.py and common/djangoapps/Third_Party_auth/tests/specs/base.py.

abdullahwaheed

tested with respective changes. LGTM

abdullahwaheed · 2023-01-12T13:22:33Z

@UvgenGen could you please rebase it again

UvgenGen · 2023-01-16T18:03:35Z

@abdullahwaheed PR rebased)

e0d · 2023-01-20T21:18:01Z

@UvgenGen should the name of this PR be updated? We're after olive, can this now be merged?

UvgenGen · 2023-01-20T22:01:28Z

@e0d I removed Note: don't merge in description, did I understand you correctly?. Yes, I think nothing prevents merge it now)

e0d · 2023-01-20T22:03:45Z

@dianakhuang is this good to merge now?
@arbrandes FYI as MFE guru and Olive release lead.

arbrandes

Looks great to me!

dianakhuang · 2023-01-24T14:27:25Z

I will try to get it on FED-BOM's agenda to review and help get this merged. Very excited for this to land!

abdullahwaheed · 2023-01-26T09:05:05Z

@UvgenGen need rebasing again due to frequent changes in platform :)
or you can give me write access to your forked repo so i can update changes.

UvgenGen · 2023-01-26T19:33:44Z

@abdullahwaheed PR rebased)

mphilbrick211 · 2023-02-24T02:30:18Z

Hi @UvgenGen @arbrandes @dianakhuang - is this good to merge once the branch conflicts are resolved?

UvgenGen · 2023-03-03T12:42:41Z

@mphilbrick211 PR rebased, conflicts resolved)

mphilbrick211 · 2023-03-07T01:41:50Z

@arbrandes @dianakhuang Would one of you be able to merge this?

openedx-webhooks · 2023-03-07T12:41:58Z

@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

edx-pipeline-bot · 2023-03-07T13:33:27Z

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot · 2023-03-07T13:54:26Z

EdX Release Notice: This PR has been deployed to the production environment.

This reverts commit 0f02c7b.

…31888)" This reverts commit 90c4ca6.

feat: Account and profile MFE legacy removal - redeployment * Revert "Revert "FC-0001: Account pages -> micro-frontend (#30336)" (#31888)" This reverts commit 90c4ca6. * refactor: removed filters test from user_api accounts --------- Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>

openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 2, 2022

This was referenced May 2, 2022

FC-0001: Account pages -> micro-frontend openedx/frontend-platform#326

Merged

FC-0001: Account pages -> micro-frontend openedx/frontend-component-header#210

Merged

openedx-webhooks added awaiting prioritization and removed needs triage labels May 3, 2022

UvgenGen force-pushed the depr/account-pages branch from 94abf32 to d306a99 Compare May 11, 2022 08:41

UvgenGen force-pushed the depr/account-pages branch from bb02e86 to 6549a21 Compare June 5, 2022 15:58

jmbowman assigned dianakhuang Jun 9, 2022

UvgenGen force-pushed the depr/account-pages branch from d2aa853 to 2a54f42 Compare June 14, 2022 10:13

openedx-webhooks removed the awaiting prioritization label Jun 14, 2022

UvgenGen force-pushed the depr/account-pages branch from 2a54f42 to a54eff5 Compare October 17, 2022 14:34

arbrandes linked an issue Oct 18, 2022 that may be closed by this pull request

[DEPR]: Account pages -> micro-frontend openedx/public-engineering#71

Closed

abdullahwaheed approved these changes Oct 19, 2022

View reviewed changes

BilalQamar95 approved these changes Dec 5, 2022

View reviewed changes

ishahroz approved these changes Dec 12, 2022

View reviewed changes

mphilbrick211 added awaiting prioritization FC Relates to an Axim Funded Contribution project labels Dec 16, 2022

mphilbrick211 removed the awaiting prioritization label Dec 27, 2022

UvgenGen force-pushed the depr/account-pages branch from a54eff5 to 6658377 Compare January 16, 2023 13:52

arbrandes approved these changes Jan 24, 2023

View reviewed changes

UvgenGen force-pushed the depr/account-pages branch from 6658377 to ed4e690 Compare January 26, 2023 19:31

UvgenGen added 7 commits March 3, 2023 14:19

feat: Account pages. Learner Profile page

389993f

feat: Account pages. Account Settings page

dde5330

feat: Account pages. Removed unused styles

a2f4920

feat: Account pages. Removed unused toggles

dbba608

feat: fixed tests and pylint errors

6e1a853

feat: update redirect to account settings for student_dashboard

d998891

feat: fix pylint errors

027e429

UvgenGen force-pushed the depr/account-pages branch from ed4e690 to 027e429 Compare March 3, 2023 12:21

abdullahwaheed merged commit 0f02c7b into openedx:master Mar 7, 2023

abdullahwaheed mentioned this pull request Mar 7, 2023

Revert "FC-0001: Account pages -> micro-frontend" #31888

Merged

dianakhuang pushed a commit that referenced this pull request Mar 7, 2023

Revert "FC-0001: Account pages -> micro-frontend (#30336)"

0573b1e

This reverts commit 0f02c7b.

rgraber pushed a commit that referenced this pull request Mar 7, 2023

Revert "FC-0001: Account pages -> micro-frontend (#30336)" (#31888)

90c4ca6

This reverts commit 0f02c7b.

abdullahwaheed added a commit that referenced this pull request Mar 8, 2023

Revert "Revert "FC-0001: Account pages -> micro-frontend (#30336)" (#…

13c8503

…31888)" This reverts commit 90c4ca6.

dianakhuang mentioned this pull request Mar 8, 2023

Handle dependencies for removing old account settings pages edx/edx-arch-experiments#218

Closed

abdullahwaheed mentioned this pull request Oct 18, 2023

feat: Account and profile MFE legacy removal - redeployment #31893

Merged

Comments

Conversation

UvgenGen commented May 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Uh oh!

openedx-webhooks commented May 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

natabene commented May 3, 2022

Uh oh!

abdullahwaheed commented Oct 17, 2022

Uh oh!

UvgenGen commented Oct 17, 2022

Uh oh!

abdullahwaheed commented Oct 17, 2022

Uh oh!

UvgenGen commented Oct 17, 2022

Uh oh!

abdullahwaheed left a comment

Choose a reason for hiding this comment

Uh oh!

abdullahwaheed commented Jan 12, 2023

Uh oh!

UvgenGen commented Jan 16, 2023

Uh oh!

e0d commented Jan 20, 2023

Uh oh!

UvgenGen commented Jan 20, 2023

Uh oh!

e0d commented Jan 20, 2023

Uh oh!

arbrandes left a comment

Choose a reason for hiding this comment

Uh oh!

dianakhuang commented Jan 24, 2023

Uh oh!

abdullahwaheed commented Jan 26, 2023

Uh oh!

UvgenGen commented Jan 26, 2023

Uh oh!

mphilbrick211 commented Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UvgenGen commented Mar 3, 2023

Uh oh!

mphilbrick211 commented Mar 7, 2023

Uh oh!

openedx-webhooks commented Mar 7, 2023

Uh oh!

edx-pipeline-bot commented Mar 7, 2023

Uh oh!

edx-pipeline-bot commented Mar 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

UvgenGen commented May 2, 2022 •

edited

Loading

openedx-webhooks commented May 2, 2022 •

edited

Loading

mphilbrick211 commented Feb 24, 2023 •

edited

Loading