Skip to content

Add lockfile check#30440

Merged
aht007 merged 1 commit intomasterfrom
aht007/Add-NPM-VERSION-CHECK
May 19, 2022
Merged

Add lockfile check#30440
aht007 merged 1 commit intomasterfrom
aht007/Add-NPM-VERSION-CHECK

Conversation

@aht007
Copy link
Contributor

@aht007 aht007 commented May 19, 2022

lockfileVersion for the package-lock.json generated by NPM6 was 1 but now as we've moved to Node16 and NPM8, package-lock.json should be generated using NPM8. lockfileVersion for package-lock.json generated using NPM8 is 2. So here we're going to check the lockfileVersion in package-lock.json

@aht007 aht007 requested a review from a team May 19, 2022 12:32
@aht007 aht007 merged commit 7deea6e into master May 19, 2022
@aht007 aht007 deleted the aht007/Add-NPM-VERSION-CHECK branch May 19, 2022 12:54
aht007 added a commit that referenced this pull request May 19, 2022
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

aht007 added a commit that referenced this pull request May 24, 2022
aht007 added a commit that referenced this pull request May 24, 2022
aht007 added a commit that referenced this pull request May 25, 2022
aht007 added a commit that referenced this pull request May 25, 2022
dmitry-viskov pushed a commit to weaveeducation/edx-platform that referenced this pull request May 27, 2022
dmitry-viskov pushed a commit to weaveeducation/edx-platform that referenced this pull request May 27, 2022
jawad-khan pushed a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments