Merged
Conversation
UsamaSadiq
approved these changes
May 23, 2022
aht007
force-pushed
the
aht007/LockFileCheck
branch
from
c46e42b to
c5cf04e
Compare
aht007
added a commit
that referenced
this pull request
May 25, 2022
dmitry-viskov
pushed a commit
to weaveeducation/edx-platform
that referenced
this pull request
May 27, 2022
dmitry-viskov
pushed a commit
to weaveeducation/edx-platform
that referenced
this pull request
May 27, 2022
…enedx#30479) This reverts commit 4a3c6df.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lockfileVersion for the package-lock.json generated by NPM6 was 1 but now as we've moved to Node16 and NPM8, package-lock.json should be generated using NPM8. lockfileVersion for package-lock.json generated using NPM8 is 2. So here we're going to check the lockfileVersion in package-lock.json