[BB-6206] Adds a openedx-filter event to hook into XBlock Rendering#30650
[BB-6206] Adds a openedx-filter event to hook into XBlock Rendering#30650tecoholic wants to merge 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @tecoholic! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
|
There are many places that XBlocks can be rendered - in LMS courseware, in Studio when editing courses, in LMS Libraries via direct learning (LabXchange is the only example), or when editing Libraries in Studio. Is the intention of this PR that it is strictly for XBlocks being rendered for courses in the LMS, or for any time an XBlock is rendered in any learning context? I would say the latter is the most flexible. For example, then you could use it to add authoring tools in Studio too. Whichever it is, the documentation should be very explicit about that, but right now I think it's ambiguous. As another example, the docstring currently says that this is only used with units ( It's also worth noting that in the mobile app, XBlocks which have native UI are only downloaded using their data via |
|
@bradenmacdonald Thank you for providing a great context. Frankly, I didn't think of the various contexts in which the XBlock could be rendered and you are absolutely right about the description being vauge. Let me dig into this more and find the right place to place this hook and also document the context better. The intention initially was to place a modify the content per unit (hence the target on VerticalBlocks). Based on the testing and the followup discussion, it is becoming clear that this should be targeted at individual XBlock level. I moving this to draft while the ambiguity is resolved. |
|
@tecoholic Thank you for your contribution. Please let me know once this is ready for our review. |
|
Closing this in favor of #30773 |
|
@tecoholic Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR introduces a new openedx-filters event
org.openedx.learning.xblock.render.started.v1hook in the platform. This is implemented a part of the PoC to implement "Edit Link" in the course content for Open Source courses.Users impacted by the change:
Supporting information
Testing instructions
This PR is 1 of the 3 PRs that implement the Edit Link PoC and should be tested in tandem.
Other related PRs
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.