Skip to content

[BB-6206] Adds a openedx-filter event to hook into XBlock Rendering #30650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tecoholic wants to merge 2 commits into from
Closed

[BB-6206] Adds a openedx-filter event to hook into XBlock Rendering #30650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf91d2b
feat: adds a filter hook for render_xblock function
tecoholic Jun 24, 2022
c648a71
fix: pass block to the XBlockRenderStarted filter
tecoholic Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lms/djangoapps/courseware/views/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
from markupsafe import escape
from opaque_keys import InvalidKeyError
from opaque_keys.edx.keys import CourseKey, UsageKey
from openedx_filters.learning.filters import CourseAboutRenderStarted
from openedx_filters.learning.filters import CourseAboutRenderStarted, XBlockRenderStarted
from pytz import UTC
from requests.exceptions import ConnectionError, Timeout # pylint: disable=redefined-builtin
from rest_framework import status
Expand Down Expand Up @@ -1605,7 +1605,17 @@ def render_xblock(request, usage_key_string, check_if_enrolled=True):

**optimization_flags,
}
return render_to_response('courseware/courseware-chromeless.html', context)
template_name = 'courseware/courseware-chromeless.html'
try:
# .. filter_implemented_name: XBlockRenderStarted
# .. filter_type: org.openedx.learning.xblock.render.started.v1
context, template_name = XBlockRenderStarted.run_filter(block, context, template_name)
except XBlockRenderStarted.RenderCustomReponse as exc:
response = exc.response
else:
response = render_to_response(template_name, context)

return response


@require_http_methods(["GET"])
Expand Down