test: remove unused helper functions from test_views.py#32559
test: remove unused helper functions from test_views.py#32559feanil merged 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @raju249! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
mphilbrick211
added
the
needs test run
e0d
changed the title
|
@raju249 We need to have a CLA on file for you before we can accept this contribution, take a look at the instructions above. Also, I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard? |
e0d
removed
the
needs test run
|
Thanks @e0d Just fixing my commit messages. Regarding CLA, I am awaiting a reply from the team, I have signed on my side. Over email conversation, I got to know that the legal team member is on leave for this week... I am fine with keeping this and the other PR open until its complete. 👍 |
raju249
force-pushed
the
31696-unused-helper-functions
branch
from
e81cb11 to
156f2fd
Compare
|
Ok, I think I messed up with merge and rebase. Let me rectify. |
raju249
force-pushed
the
31696-unused-helper-functions
branch
from
4bd5cce to
927a8e4
Compare
raju249
changed the title
|
@e0d - CLA is complete. Can you or someone else please help me with a review on this PR? |
raju249
changed the title
raju249
changed the title
Since they were not used anywhere, it is ideal to delete them. It would be redundant to keep them.
raju249
force-pushed
the
31696-unused-helper-functions
branch
from
a104f26 to
ad3b561
Compare
|
@e0d - can you help re-run the pipeline, please? |
|
@raju249 I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run. |
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Yep, looks like these aren't used in platform testing anywhere.
|
I'll coordinate merging. |
|
@raju249 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
6 participants
Description
Resolves #31696
Deletes two unused helper functions from
lms/djangoapps/teams/tests/test_views.py.Supporting information
NA
Testing instructions
Running
lms/djangoapps/teams/tests/test_views.pyshould pass as expected before this change.Deadline
None
Other information
NA