Skip to content

test: remove unused helper functions from test_views.py #32559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feanil merged 2 commits into from
Jul 3, 2023
Merged

test: remove unused helper functions from test_views.py #32559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad3b561
test: remove unused helper functions from test_views.py
Jun 23, 2023
462e8be
Merge branch 'master' into 31696-unused-helper-functions
e0d Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 0 additions & 69 deletions lms/djangoapps/teams/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,49 +188,6 @@ def test_bad_course_id(self):
response = self.client.get(bad_team_url)
assert 404 == response.status_code

def get_user_course_specific_teams_list(self):
"""Gets the list of user course specific teams."""

# Create a course two
course_two = CourseFactory.create(
teams_configuration=TeamsConfig({
"max_team_size": 1,
"topics": [
{
"name": "Test topic for course two",
"id": 1,
"description": "Description for test topic for course two."
}
]
})
)

# Login and enroll user in both course course
self.client.login(username=self.user.username, password=self.test_password)
CourseEnrollmentFactory.create(user=self.user, course_id=self.course.id)
CourseEnrollmentFactory.create(user=self.user, course_id=course_two.id)

# Create teams in both courses
course_one_team = CourseTeamFactory.create(name="Course one team", course_id=self.course.id, topic_id=1)
course_two_team = CourseTeamFactory.create( # pylint: disable=unused-variable
name="Course two team", course_id=course_two.id, topic_id=1,
)

# Check that initially list of user teams in course one is empty
course_one_teams_url = reverse('teams_dashboard', args=[self.course.id])
response = self.client.get(course_one_teams_url)
self.assertContains(response, '"teams": {"count": 0')
# Add user to a course one team
course_one_team.add_user(self.user)

# Check that list of user teams in course one is not empty, it is one now
response = self.client.get(course_one_teams_url)
self.assertContains(response, '"teams": {"count": 1')
# Check that list of user teams in course two is still empty
course_two_teams_url = reverse('teams_dashboard', args=[course_two.id])
response = self.client.get(course_two_teams_url)
self.assertContains(response, '"teams": {"count": 0')

@ddt.unpack
@ddt.data(
(True, False, False),
Expand Down Expand Up @@ -673,32 +630,6 @@ def get_teams_list(self, expected_status=200, data=None, no_course_id=False, **k
data.update({'course_id': str(self.test_course_1.id)})
return self.make_call(reverse('teams_list'), expected_status, 'get', data, **kwargs)

def get_user_course_specific_teams_list(self):
"""Gets the list of user course specific teams."""

# Create and enroll user in both courses
user = self.create_and_enroll_student(
courses=[self.test_course_1, self.test_course_2],
username='test_user_enrolled_both_courses'
)
course_one_data = {'course_id': str(self.test_course_1.id), 'username': user}
course_two_data = {'course_id': str(self.test_course_2.id), 'username': user}

# Check that initially list of user teams in course one is empty
team_list = self.get_teams_list(user=user, expected_status=200, data=course_one_data)
assert team_list['count'] == 0

# Add user to a course one team
self.solar_team.add_user(self.users[user])

# Check that list of user teams in course one is not empty now
team_list = self.get_teams_list(user=user, expected_status=200, data=course_one_data)
assert team_list['count'] == 1

# Check that list of user teams in course two is still empty
team_list = self.get_teams_list(user=user, expected_status=200, data=course_two_data)
assert team_list['count'] == 0

def build_team_data(
self,
name="Test team",
Expand Down