"Bare Bones" UI for Problem Bank [FC-0062]#35679
Conversation
|
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
bradenmacdonald
force-pushed
the
braden/pool-ui
branch
from
5939b5d to
7456c0a
Compare
bradenmacdonald
force-pushed
the
braden/pool-ui
branch
4 times, most recently
from
a36a103 to
a3a968f
Compare
| 'selected_groups_label': selected_groups_label, | ||
| 'can_add': context.get('can_add', True), | ||
| 'can_add': can_add, | ||
| 'can_delete': can_add or (root_xblock and root_xblock.scope_ids.block_type == "itembank"), |
There was a problem hiding this comment.
[request] Please add a comment explaining this special-casing of itembank behavior.
xmodule/item_bank_block.py
Outdated
| ) | ||
| ) | ||
| elif len(self.children) < self.max_count: | ||
| elif len(self.children) > 0 and len(self.children) < self.max_count: |
There was a problem hiding this comment.
[nit, optional]: You can also do this as elif 0 < len(self.children) < self.max_count
xmodule/item_bank_block.py
Outdated
| if is_root and self.children: | ||
| # User has clicked the "View" link. Show a preview of all possible children: | ||
| max_count = self.max_count | ||
| if max_count < 0: |
There was a problem hiding this comment.
[nit, optional]: The usage of max_count == -1 as "grab all the things" is both frequent and obscure to anyone just glancing at the code for the first time. It might be worth making a constant or a helper or something to make the intent clearer, e.g. if self.max_count == self.SELECT_ALL_CHILDREN or something.
There was a problem hiding this comment.
I agree, but gonna leave it for now.
|
Thanks @ormsbee. Done. |
|
@bradenmacdonald: Once you've got all the CI passing, could you please squash the commits tonight so @kdmccormick or I can merge first thing in the morning our time? |
DanielVZ96
force-pushed
the
braden/pool-ui
branch
from
84fea29 to
35765ed
Compare
bradenmacdonald
force-pushed
the
braden/pool-ui
branch
from
35765ed to
9e28ba9
Compare
|
@ormsbee Done, should be ready for merge. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
5 participants
Description
This implements a minimal UI so that the WIP Problem Bank XBlock is usable:
Problem.Bank.Bare.Bones.Demo.mov
Detailed summary
Supports various cases:
Supporting information
Implements openedx/frontend-app-authoring#1385 . Private ref FAL-3898.
Currently depends on / includes commits from several other PRs:
Testing instructions
See video and try following along on your own devstack.
Deadline
ASAP - need this in Sumac
TODO
Before merging:
In follow-up PRs: