build: Remove unneccessary built-in XBlock Sass built steps#35833
Conversation
| if not css_absolute_path.is_file(): | ||
| raise FileNotFoundError(f"css file not found: {css_absolute_path}") | ||
| css_static_path = Path('css-builtin-blocks') / css_relative_path.with_suffix('.css') | ||
| css_url = get_static_file_url(str(css_static_path)) # get_static_file_url is theme-aware. |
There was a problem hiding this comment.
Note for reviewers: I removed this comment because this step is not theme aware any more. It will always return the same CSS file regardless of theme. Theme customizations will instead be injected via the CSS variables defined in common/static/sass/_builtin-block-variables.
Since all built-in block Sass is gone, we remove two final pieces of code: * the steps in `npm run compile-sass` which compiled `xmodule/assets`, and * the now-unused `add_sass_to_fragment` function. This should speed up the edx-platform assets build a little bit. This commit also includes some minor dev doc updates. Part of: openedx#35300
kdmccormick
force-pushed
the
kdmccormick/xmodule-sass-final-cleanup
branch
from
9f4cccb to
b323c2a
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
3 participants
Description
Since all built-in block Sass is gone, we remove two final pieces of code:
npm run compile-sasswhich compiledxmodule/assets, andadd_sass_to_fragmentfunction.This should speed up the edx-platform assets build a little bit.
This commit also includes some minor dev doc updates.
Supporting info
#35300
Testing instructions
npm run build-dev. Ensure there are no errors logged.