Hotfix/2020.1.2 #1738
Merged
Hotfix/2020.1.2 #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a_due_to_mandatory_fields Contribution wizard lost metadata fix
…a_issue_in_moderation Fix the mandatory fields bug in moderation
|
Oh, I was about to restart Travis like I did for #1738 but then I realised it looked like the same suites failed (controls). Further, it failed on both old and new UI and I notice the new test failed. Maybe the new test is flaky, or otherwise there's an issue with the fix? |
Note: This is a hack, and should be done more elegantly. We should not be using dangerouslySetInnerHTML.
Rather than using security risk dangerouslySetInnerHtml. Also - remove test strings from LegacyContentApi.scala and use idiomatic Scala code to setup the form.
…round Make Canvas Integration work with new UI
|
@cbeach47 @ChristianMurphy - I believe that 6c7b710 could fix the Bb selection session issue - its a fix for a very similar bug in Canvas. Would you be able to check this branch out and test? |
…ting_bug_test Simplify VisibilityScriptingBugTest and add test retries to TestNG tests
…t-work Replace the testing url for ItemSummaryTest
cbeach47
approved these changes
May 27, 2020
There was a problem hiding this comment.
I did not do a code review, but I confirmed:
- Using Blackboard original course view and oEQ LTI tool provider with oEQ in the new UI, the selection session launches
- single and multiple selections work
- confirmed in Chrome, FF, and Edge
I noted the following warning, but it wasn't a blocker:
Source map error: Error: request failed with status 404
Resource URL: http://192.168.1.143:8090/local/p/r/2020.1.2/com.equella.core/reactjs/entrybuild.bb660c5a.js
Source Map URL: reactjs/entrybuild.bb660c5a.js.map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
#1679