-
Notifications
You must be signed in to change notification settings - Fork 44
CDM 2019 10
SammyIsConfused edited this page Oct 4, 2019
·
5 revisions
2019-10-03 (US) / 2019-10-04 (AU)
- Chair: NickC
- Scribe: SamF
List of attendees: Samantha Fisher, Chris Beach, Aaron Holland, Cath Fitzgerald, Nick Charles, Christan Murphy, Ian Stevenson, Penghai Zhang
- Review Action Items
- Specific Topics (Please add to below list, or email the equella dev list to have an item added)
- Discuss code enhancements since last CDM
- Review tech choices, code structures, direction
- Any tech debt concerns
- Open PRs to discuss
- Q&A
- Pull Request checklist / template - IS/CB
- Where did we get to with JS testing? - IS
- Committership - develop a check list for Committers expected standards and minimum meeting attendance requirements (provides ability to merge PRs) - CB
- openEQUELLA-Toolbox:CheckFiles - now in use. Call for changes before turning into a background task - CB
- Please add more
- We've moved to using monday.com as our release checklist
- CF states that it isn't an exact science and that she doesn't see a direct benefit to a community release checklist
- CB points out that it would be good to have the community help out with releases
- IS says that we could potentially have a high level overview document that we could then link in to the roadmap
- CB would like to be able to create hotfix branches
- In the meantime, CF can send a list of hotfix steps to CB
- Wait til we aren't using the version server anymore to simplify the process
- IS did an initial review of how it works
- Hopefully this can be done for 2019.2, best case sooner
- Captured in #1269 issue on Github
- Moved to done
- Definitely in progress, most of the Edalex staff are running off a fork
- Have done some fixes to the codebase to support it
- Moved to done
- We've had some discussions in CDMs as to what PRs should look like. Should definitely have tests.
- Should be a checklist - "thank you for your PR, have you followed these steps?"
- Prevents untested code from entering the code base, shortens review times
- Point to issue
- CB created a ticket, has not had an opportunity to tackle it
- This was more as a curiosity, although will become more important as we move toward the new UI
Committership - develop a check list for Committers expected standards and minimum meeting attendance requirements (provides ability to merge PRs)
- This has been discussed in the advisory board
- Advisory board thinks this is a good idea. We don't want to exclude people, but we want to have at least some guardianship over this
- Advisory board would like to see a checklist for this purpose, I.E. once approved you can be a committer
- Potentially, you should have a minimum CDM attendance requirement
openEQUELLA-Toolbox:CheckFiles - now in use. Call for changes before turning into a background task - CB
- CB has written scripts during consulting for US clients
- Unified them into the openEQULLA-Toolbox
- Currently just a CLI
- CheckFiles - one client is experiencing missing files as an ongoing problem
- This has unit tests, built with gradle
- The client is now using it to monitor their openEQUELLA
- There are configuration options for replacing encoded characters with specified characters
- Doesn't currently handle zip files properly
- CB has let other adopters know that this is happening, recommended that it should be run
- Three adopters in the US are experiencing the issue
- Potentially related to the staging area background task
- Unicon is aiming towards increasing confidence in openEQUELLA
- CB would like this to be a background openEQUELLA task at some point
- It only does read only db calls and file existence checks
- CB says that it is potentially worth turning off the Slack
- Focus on the google group instead
- IS points out that they can always be reopened when they are being worked on
- Stalebot has a collection of labels that will not be staled - "Pinned"
- 2019.1.1 has been released
- Entailed changes made to support semantic versioning
- Now supported by oEQ and the build tools, and the releases page, and the upgrader
- Next step forward - changing the way we do version checking to use GH releases page rather than the version server
No tech choice minutes this month.
- To be discussed next meeting
- Ready for review, passing tests