This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Convert std::test benchmarks to use Criterion
#10999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
tobz1000
changed the title
std::test benchmarks to use Criterion
tobz1000
commented
Aug 28, 2019
|
[clabot:check] |
|
It looks like @tobz1000 signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
ordian
added
the
A5-grumble 🔥
ordian
added
A8-looksgood 🦄
Co-Authored-By: Andronik Ordian <write@reusable.software>
|
merge with master should fix cargo audit |
ordian
reviewed
Sep 4, 2019
dvdplm
approved these changes
Sep 5, 2019
dvdplm
added a commit
that referenced
this pull request
Sep 9, 2019
* master: fix: remove unused error-chain (#11028) fix: remove needless use of itertools (#11029) Convert `std::test` benchmarks to use Criterion (#10999) Fix block detail updating (#11015) [trace] introduce trace failed to Ext (#11019) cli: update usage and version headers (#10924) [private-tx] remove unused rand (#11024)
dvdplm
added a commit
that referenced
this pull request
Sep 10, 2019
…he-right-place * master: cleanup json crate (#11027) [spec] add istanbul test spec (#11033) [json-spec] make blake2 pricing spec more readable (#11034) Add blake2_f precompile (#11017) Add new line after writing block to hex file. (#10984) fix: remove unused error-chain (#11028) fix: remove needless use of itertools (#11029) Convert `std::test` benchmarks to use Criterion (#10999) Fix block detail updating (#11015) [trace] introduce trace failed to Ext (#11019) cli: update usage and version headers (#10924) [private-tx] remove unused rand (#11024)
dvdplm
added a commit
that referenced
this pull request
Sep 13, 2019
* master: (70 commits) ethcore: remove `test-helper feat` from build (#11047) Include test-helpers from ethjson (#11045) [ethcore]: cleanup dependencies (#11043) add more tx tests (#11038) Fix parallel transactions race-condition (#10995) [ethcore]: make it compile without `test-helpers` feature (#11036) Benchmarks for block verification (#11035) Move snapshot related traits to their proper place (#11012) cleanup json crate (#11027) [spec] add istanbul test spec (#11033) [json-spec] make blake2 pricing spec more readable (#11034) Add blake2_f precompile (#11017) Add new line after writing block to hex file. (#10984) fix: remove unused error-chain (#11028) fix: remove needless use of itertools (#11029) Convert `std::test` benchmarks to use Criterion (#10999) Fix block detail updating (#11015) [trace] introduce trace failed to Ext (#11019) cli: update usage and version headers (#10924) [private-tx] remove unused rand (#11024) ...
dvdplm
added a commit
that referenced
this pull request
Nov 8, 2019
dvdplm
added
the
B0-patch-stable 🕷
dvdplm
added a commit
that referenced
this pull request
Nov 8, 2019
niklasad1
pushed a commit
that referenced
this pull request
Nov 8, 2019
* Convert std::test benches to Criterion * Required feature for ethash benches * gitlab-ci: Check all bench targets * check ethash benches * evmbin/benches/mod.rs: Update bench sample command Co-Authored-By: Andronik Ordian <write@reusable.software> * Upgrade to criterion 0.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10975.
I've replaced the
ethcorebench check with a check for all benches, hopefully as desired in the issue.Query: I've stuck to 2015-style imports in the modified source files, to minimise changes. Is this the correct style, or should modified files be updated to 2018-style imports?
Also modified
ethashmanifest so that benches should check okay withcargo check --all --benches.