Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[spec] add istanbul test spec #11033

Merged
merged 6 commits into from
Sep 10, 2019
Merged

[spec] add istanbul test spec #11033

merged 6 commits into from
Sep 10, 2019

Conversation

ordian
Copy link
Collaborator

@ordian ordian commented Sep 10, 2019

Closes #11032.

@ordian ordian added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M2-config 📂 Chain specifications and node configurations. labels Sep 10, 2019
@ordian ordian added this to the 2.7 milestone Sep 10, 2019
@ordian ordian mentioned this pull request Sep 10, 2019
Closed
@ordian ordian changed the title [spec] add istanbul test spec (wip) [spec] add istanbul test spec Sep 10, 2019
@ordian ordian added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Sep 10, 2019
@ordian ordian marked this pull request as ready for review September 10, 2019 12:45
@ordian ordian merged commit fc9a293 into master Sep 10, 2019
@ordian ordian deleted the ao-istanbul-test-spec branch September 10, 2019 16:28
dvdplm
dvdplm reviewed Sep 10, 2019
View reviewed changes
json/src/spec/spec.rs
@@ -31,6 +31,7 @@ pub enum ForkSpec {
Byzantium,
Constantinople,
ConstantinopleFix,
Istanbul,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ordian This enum throws warnings for each variant. :/ Either we add dummy docs or annotate it #[allow(missing_docs)].

Copy link
Collaborator

@niklasad1 niklasad1 Sep 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is probably my fault in #11027, enabled the lint warn_missing_docs

dvdplm added a commit that referenced this pull request Sep 10, 2019
@dvdplm
Merge branch 'master' into dp/chore/extract-snapshot-with-traits-in-t…
a21731c 
…he-right-place

* master:
  cleanup json crate (#11027)
  [spec] add istanbul test spec (#11033)
  [json-spec] make blake2 pricing spec more readable (#11034)
  Add blake2_f precompile (#11017)
  Add new line after writing block to hex file. (#10984)
  fix: remove unused error-chain (#11028)
  fix: remove needless use of itertools (#11029)
  Convert `std::test` benchmarks to use Criterion (#10999)
  Fix block detail updating (#11015)
  [trace] introduce trace failed to Ext (#11019)
  cli: update usage and version headers (#10924)
  [private-tx] remove unused rand (#11024)
sorpaas
sorpaas reviewed Sep 10, 2019
View reviewed changes
ethcore/res/ethereum/istanbul_test.json
"eip145Transition": "0x0",
"eip1014Transition": "0x0",
"eip1052Transition": "0x0",
"eip1283Transition": "0x0",
Copy link
Collaborator

@sorpaas sorpaas Sep 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual config we need to write for Ethereum mainnet also has “eip1283DisableTransition”, so we “technically” need one here as well. But because it’s the same block as reenable transition, it won’t matter for this test config.

dvdplm added a commit that referenced this pull request Sep 13, 2019
@dvdplm
Merge branch 'master' into dp/chore/new-ethereum-consensus-tests
bd0f53a 
* master: (70 commits)
  ethcore: remove `test-helper feat` from build (#11047)
  Include test-helpers from ethjson (#11045)
  [ethcore]: cleanup dependencies (#11043)
  add more tx tests (#11038)
  Fix parallel transactions race-condition (#10995)
  [ethcore]: make it compile without `test-helpers` feature (#11036)
  Benchmarks for block verification (#11035)
  Move snapshot related traits to their proper place (#11012)
  cleanup json crate (#11027)
  [spec] add istanbul test spec (#11033)
  [json-spec] make blake2 pricing spec more readable (#11034)
  Add blake2_f precompile (#11017)
  Add new line after writing block to hex file. (#10984)
  fix: remove unused error-chain (#11028)
  fix: remove needless use of itertools (#11029)
  Convert `std::test` benchmarks to use Criterion (#10999)
  Fix block detail updating (#11015)
  [trace] introduce trace failed to Ext (#11019)
  cli: update usage and version headers (#10924)
  [private-tx] remove unused rand (#11024)
  ...
@soc1c soc1c mentioned this pull request Sep 19, 2019
Merged
@ordian ordian mentioned this pull request Sep 25, 2019
Merged
ordian added a commit that referenced this pull request Sep 25, 2019
@ordian
Manual backport of #11033
2621ef2
s3krit added a commit that referenced this pull request Sep 26, 2019
@s3krit
v2.5.9-stable (#11089)
b2277f6 
* ethcore/res: activate Istanbul on Ropsten, Görli, Rinkeby, Kovan (#11068)

* ethcore/res: activate Istanbul on Ropsten block 6485846

* ethcore/res: activate Istanbul on Goerli block 1561651

* ethcore/res: use hex values for Istanbul specs

* ethcore/res: fix trailing comma

* ethcore/res: be pedantic about EIP-1283 in Petersburg and Istanbul test specs

* ethcore/res: activate Istanbul on Rinkeby block 5435345

* ethcore/res: activate Istanbul on Kovan block 14111141

* ethcore/res: fix kovan istanbul number to 0xd751a5

* [json-spec] make blake2 pricing spec more readable (#11034)

* [json-spec] make blake2 pricing spec more readable

* [ethcore] fix compilation

* Manual backport of #11033
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm left review comments

@sorpaas sorpaas sorpaas left review comments

@niklasad1 niklasad1 niklasad1 approved these changes

@jam10o-new jam10o-new jam10o-new approved these changes

Assignees
No one assigned
Labels
A0-pleasereview 🤓 Pull request needs code review. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.

Enable Istanbul in state tests
5 participants
@ordian @dvdplm @sorpaas @niklasad1 @jam10o-new