This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases it is possible for the same trie node to added twice in the same block. E.g.:
Transaction A adds a storage value for contract C at address 0 to 1. The nodes for this changes are committed to transaction memory overlay. Reference counter is set to 1.
Transaction B resets the same storage value to 0. Storage key is marked as modified in the account state cache.
Transaction B immediately changes the value back to 1. Storage key is reset to original value but still marked as modified.
Transaction B gets committed and the node gets re-inserted with counter set to 2.
I've considered keeping the original value in the state cache to detect such cases but this complicates the code and seems too expensive for such a rare case.
Fixes #2012