Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

always process trie death row on commit, add more tracing #2025

Merged
merged 1 commit into from
Sep 1, 2016

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Aug 31, 2016

When a trie is "obliterated" by a removal -- such that it only has an empty root node remaining, the root node handle was replaced with NodeHandle::Hash(SHA3_NULL_RLP). However, the commit process would only enact deletions if the node handle type was in-memory. Future insertions could then lead to double-insertions of trie nodes into the backing database.

Also boxes branch children to reduce memory churn.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Aug 31, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 85.339% when pulling c61da07 on triedbmut_double_insert into 25e6a4e on master.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 31, 2016
@rphmeier rphmeier merged commit c8f3be2 into master Sep 1, 2016
@rphmeier rphmeier deleted the triedbmut_double_insert branch September 1, 2016 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants