This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
always process trie death row on commit, add more tracing #2025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a trie is "obliterated" by a removal -- such that it only has an empty root node remaining, the root node handle was replaced with
NodeHandle::Hash(SHA3_NULL_RLP)
. However, the commit process would only enact deletions if the node handle type was in-memory. Future insertions could then lead to double-insertions of trie nodes into the backing database.Also boxes branch children to reduce memory churn.