This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Adjustable stack size for EVM #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
the
A3-inprogress ⏳
|
Changes Unknown when pulling f2186f5 on stack-evm into * on master*. |
NikVolf
added
A0-pleasereview 🤓
arkpar
reviewed
Oct 6, 2016
| /// TODO [todr] We probably need some more sophisticated calculations here (limit on my machine 132) | ||
| /// Maybe something like here: `https://github.com/ethereum/libethereum/blob/4db169b8504f2b87f7d5a481819cfb959fc65f6c/libethereum/ExtVM.cpp` | ||
| const MAX_VM_DEPTH_FOR_THREAD: usize = 64; | ||
| const STACK_SIZE_PER_DEPTH: usize = 256*1024; |
There was a problem hiding this comment.
256kb per recursion frame? That's too much. Before the change it was 512k / 64 = 8kb
512k is the minimum stack size that we supported
There was a problem hiding this comment.
before change it was 2MB/64 = 32kb
i just used 16MB/64 instead, my bad
arkpar
reviewed
Oct 6, 2016
| /// Stack size | ||
| /// Should be modified if it is changed in Rust since it is no way | ||
| /// to know or get it | ||
| pub static LOCAL_STACK_SIZE: Cell<usize> = Cell::new(::std::env::var("RUST_MIN_STACK").ok().and_then(|s| s.parse().ok()).unwrap_or(2 * 1024 * 1024)); |
There was a problem hiding this comment.
minimum should be 512k, that's the default on OS X
There was a problem hiding this comment.
512k must be default for the main thread only
this expression exactly the same value which rust uses for spawned threads:
https://github.com/rust-lang/rust/blob/master/src/libstd/sys/common/util.rs#L18
arkpar
reviewed
Oct 6, 2016
|
|
||
| use std::sync::{Condvar as SCondvar, Mutex as SMutex}; | ||
|
|
||
| const STACK_SIZE: usize = 16*1024*1024; |
There was a problem hiding this comment.
Looks like with 8kb frame the stack of 8mb should be enough
There was a problem hiding this comment.
this might be so, but previously we used 32kb
see above
arkpar
added
A4-gotissues 💥
|
Changes Unknown when pulling be2307f on stack-evm into * on master*. |
|
well 16kb was not enough |
|
Changes Unknown when pulling 841401e on stack-evm into * on master*. |
NikVolf
added
A0-pleasereview 🤓
|
Changes Unknown when pulling 7b956a8 on stack-evm into * on master*. |
arkpar
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Oct 7, 2016
* stack size for io workers & evm threshold * rust way to remember stack size * right value * 24kb size * some stack reduction
gavofyork
pushed a commit
that referenced
this pull request
Oct 7, 2016
* RocksDB version bump * Preserve cache on reverting the snapshot (#2488) * Preserve cache on reverting the snapshot * Renamed merge_with into replace_with * Renamed and documented snapshotting methods * Track dirty accounts in the state (#2461) * State to track dirty accounts * Removed clone_for_snapshot * Renaming stuff * Documentation and other minor fixes * Replaced MaybeAccount with Option * Adjustable stack size for EVM (#2483) * stack size for io workers & evm threshold * rust way to remember stack size * right value * 24kb size * some stack reduction * Fixed overflow panic in handshake_panic (#2495)
jacogr
added a commit
that referenced
this pull request
Oct 8, 2016
* js: (228 commits) registration in place Backports to master (#2530) lookup hash ethcore_hashContent call single input for commit/filename basic githubhint layout Handle reorganizations in the state cache (#2490) terminate after 30 seconds (#2513) allow updates of the secure token Using pending block only if not old (#2514) Caching optimizations (#2505) rework connection display basic test for manual token Fixed overflow panic in handshake_panic (#2495) Trim password from file (#2503) Fixing RPC Filter conversion to EthFilter (#2500) init token updates take place initial token connection - WIP Fixing error message for transactions (#2496) Adjustable stack size for EVM (#2483) ... # Conflicts: # js/src/dapps/registry/Application/application.js # js/src/dapps/registry/Container.js # js/src/dapps/registry/actions.js # js/src/dapps/registry/reducers.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2482