Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixed possible panic in the networking #2495

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Fixed possible panic in the networking #2495

merged 1 commit into from
Oct 7, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Oct 6, 2016

No description provided.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Oct 6, 2016
@@ -591,7 +591,10 @@ impl Host {
}

fn handshake_count(&self) -> usize {
self.sessions.read().count() - self.session_count()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saturating_sub?

Copy link
Collaborator Author

@arkpar arkpar Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0001%) to 86.41% when pulling ce0b4fe on handshake-overflow into e380955 on master.

@arkpar arkpar force-pushed the handshake-overflow branch from ce0b4fe to 5c36ac4 Compare October 6, 2016 15:52
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 86.433% when pulling 5c36ac4 on handshake-overflow into 6c1b2fb on master.

@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 7, 2016
@arkpar arkpar merged commit 533af43 into master Oct 7, 2016
arkpar added a commit that referenced this pull request Oct 7, 2016
gavofyork pushed a commit that referenced this pull request Oct 7, 2016
* RocksDB version bump

* Preserve cache on reverting the snapshot (#2488)

* Preserve cache on reverting the snapshot

* Renamed merge_with into replace_with

* Renamed and documented snapshotting methods

* Track dirty accounts in the state (#2461)

* State to track dirty accounts

* Removed clone_for_snapshot

* Renaming stuff

* Documentation and other minor fixes

* Replaced MaybeAccount with Option

* Adjustable stack size for EVM (#2483)

* stack size for io workers & evm threshold

* rust way to remember stack size

* right value

* 24kb size

* some stack reduction

* Fixed overflow panic in handshake_panic (#2495)
jacogr added a commit that referenced this pull request Oct 8, 2016
* js: (228 commits)
  registration in place
  Backports to master (#2530)
  lookup hash
  ethcore_hashContent call
  single input for commit/filename
  basic githubhint layout
  Handle reorganizations in the state cache (#2490)
  terminate after 30 seconds (#2513)
  allow updates of the secure token
  Using pending block only if not old (#2514)
  Caching optimizations (#2505)
  rework connection display
  basic test for manual token
  Fixed overflow panic in handshake_panic (#2495)
  Trim password from file (#2503)
  Fixing RPC Filter conversion to EthFilter (#2500)
  init token updates take place
  initial token connection - WIP
  Fixing error message for transactions (#2496)
  Adjustable stack size for EVM (#2483)
  ...

# Conflicts:
#	js/src/dapps/registry/Application/application.js
#	js/src/dapps/registry/Container.js
#	js/src/dapps/registry/actions.js
#	js/src/dapps/registry/reducers.js
@gavofyork gavofyork deleted the handshake-overflow branch November 3, 2016 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants