This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
removed "rustup" & added new runner tag #9731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
gabreal
approved these changes
Oct 10, 2018
|
this will switch the windows build to the new azure windows 10 runners - in case something goes wrong one can simply apply the windows tag to the old runners 👍 |
5chdn
reviewed
Oct 10, 2018
5chdn
added
A0-pleasereview 🤓
|
new tags for runners are planned, more standard and understandable. like |
General-Beck
approved these changes
Oct 10, 2018
5chdn
suggested changes
Oct 11, 2018
|
ok, i changed the tag to (just) windows and added the new tag to the runner settings of betelgeuse and bellatrix so we can managed the migration from the old to the new runners nodes in gitlab instead of changing the gitlab-ci.yml in the future. |
|
Hehe, but why aren't we just applying the rust-windows tag to the new runners? This way we won't need any changes to the current gitlab-ci YML? :) |
This was referenced Oct 15, 2018
|
@5chdn good to go now? The tag name was reverted. This is required to test the new windows CI hosts.. |
This was referenced Oct 20, 2018
5chdn
pushed a commit
that referenced
this pull request
Oct 26, 2018
* removed "rustup" & added new runner tag * exchanged tag "rust-windows" with "windows" * revert windows tag change
ordian
pushed a commit
that referenced
this pull request
Oct 26, 2018
* removed "rustup" & added new runner tag * exchanged tag "rust-windows" with "windows" * revert windows tag change
5chdn
added a commit
that referenced
this pull request
Oct 28, 2018
* version: bump parity beta to 2.1.4 * ethcore: bump ropsten forkblock checkpoint (#9775) * ethcore: handle vm exception when estimating gas (#9615) * removed "rustup" & added new runner tag (#9731) * removed "rustup" & added new runner tag * exchanged tag "rust-windows" with "windows" * revert windows tag change * sync: retry different peer after empty subchain heads response (#9753) * If no subchain heads then try a different peer * Add log when useless chain head * Restrict ChainHead useless peer to ancient blocks * sync: replace `limit_reorg` with `block_set` condition * update jsonrpc-core to a1b2bb742ce16d1168669ffb13ffe856e8131228 * Allow zero chain id in EIP155 signing process (#9792) * Allow zero chain id in EIP155 signing process * Rename test * Fix test failure * Insert dev account before unlocking (#9813)
5chdn
added a commit
that referenced
this pull request
Oct 28, 2018
* version: bump parity stable to 2.0.9 * ethcore: bump ropsten forkblock checkpoint (#9775) * ethcore: handle vm exception when estimating gas (#9615) * update jsonrpc-core to a1b2bb742ce16d1168669ffb13ffe856e8131228 * removed "rustup" & added new runner tag (#9731) * removed "rustup" & added new runner tag * exchanged tag "rust-windows" with "windows" * revert windows tag change * Allow zero chain id in EIP155 signing process (#9792) * Allow zero chain id in EIP155 signing process * Rename test * Fix test failure * Insert dev account before unlocking (#9813)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(https://gitlab.parity.io/parity/devops/blob/master/ansible/roles/win-gitlab-runner/tasks/main.yml)