This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Allow zero chain id in EIP155 signing process #9792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
added
A0-pleasereview 🤓
|
Tests are failing |
|
We need to either:
|
|
Reopening this for a while as I'm really confused why those tests fail. |
sorpaas
added
A3-inprogress ⏳
sorpaas
added
A0-pleasereview 🤓
ordian
approved these changes
Oct 26, 2018
ordian
added
A8-looksgood 🦄
This was referenced Oct 26, 2018
ascjones
approved these changes
Oct 26, 2018
ordian
pushed a commit
that referenced
this pull request
Oct 26, 2018
* Allow zero chain id in EIP155 signing process * Rename test * Fix test failure
ordian
pushed a commit
that referenced
this pull request
Oct 26, 2018
* Allow zero chain id in EIP155 signing process * Rename test * Fix test failure
5chdn
added a commit
that referenced
this pull request
Oct 28, 2018
* version: bump parity beta to 2.1.4 * ethcore: bump ropsten forkblock checkpoint (#9775) * ethcore: handle vm exception when estimating gas (#9615) * removed "rustup" & added new runner tag (#9731) * removed "rustup" & added new runner tag * exchanged tag "rust-windows" with "windows" * revert windows tag change * sync: retry different peer after empty subchain heads response (#9753) * If no subchain heads then try a different peer * Add log when useless chain head * Restrict ChainHead useless peer to ancient blocks * sync: replace `limit_reorg` with `block_set` condition * update jsonrpc-core to a1b2bb742ce16d1168669ffb13ffe856e8131228 * Allow zero chain id in EIP155 signing process (#9792) * Allow zero chain id in EIP155 signing process * Rename test * Fix test failure * Insert dev account before unlocking (#9813)
5chdn
added a commit
that referenced
this pull request
Oct 28, 2018
* version: bump parity stable to 2.0.9 * ethcore: bump ropsten forkblock checkpoint (#9775) * ethcore: handle vm exception when estimating gas (#9615) * update jsonrpc-core to a1b2bb742ce16d1168669ffb13ffe856e8131228 * removed "rustup" & added new runner tag (#9731) * removed "rustup" & added new runner tag * exchanged tag "rust-windows" with "windows" * revert windows tag change * Allow zero chain id in EIP155 signing process (#9792) * Allow zero chain id in EIP155 signing process * Rename test * Fix test failure * Insert dev account before unlocking (#9813)
This was referenced Nov 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP155 actually didn't specify chainid 0 is invalid, and it can be valid --
35means refined v to be0, and36means refined v to be1. This PR fixes that.