-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for the --watch flag for faas-cli up #969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes issue where all functions are rebuilt even if only one changed * Fixes issue where unrelated files cause rebuilds * Fixes issue where vim can't trigger and update due to using create * Adds newly created folders into the watch when within a function's path * Triggers rebuilds via stack.yml Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
nitishkumar71
suggested changes
Jun 30, 2023
nitishkumar71
suggested changes
Jun 30, 2023
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Fixes a bug where localrun was sending an empty string to the fprocess variable for the dockerfile template. This is a problem because the template will never define this variable, it's set in the Dockerfile. So whilst a manual docker run command worked, the localrun command did not. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
I've added a note on why --watch won't work with localrun with the current design. We need some kind of Go routine, cancellation/context approach so that the docker run which is blocking, doesn't block the watcher code - and the watcher code has a chance to kill the docker run for a prior version before starting a new build/run. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the --watch flag for faas-cli up due to incomplete / defective feature PR.
Description
Motivation and Context
Fixes: #968
How Has This Been Tested?
Tested with:
faas-cli new --append
during a watchTypes of changes