Implement --watch for local-run with cancellation support #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds --watch support to localrun by using a context to cancel and remove any running container when a change is detected. watchLoop has been updated to support a context. Tested with VSCode - I suggest turning auto-save off when using this feature. Tested again with faas-cli up to make sure there was no regression: https://asciinema.org/a/594072 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
This change moves the reload message to where it can be seen instead of having it printed out mid-flow during the up sequence. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
force-pushed
the
localrun-watch
branch
from
31ff2ce
to
bd295b0
Compare
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Publish and deploy is quicker than build push and deploy because it doesn't run two commands and doesn't put data into the local library first. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
changed the title
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement --watch for localrun with cancellation support
Motivation and Context
faas-cli local-run -- watchand related to fixes in Fixes for the --watch flag for faas-cli up #969 which were forfaas-cli up --watch--publishflag forup, so thatupcan be used with--platformsand for faster builds when iterating.How Has This Been Tested?
This commit adds --watch support to localrun by using a context to cancel and remove any running container when a change is detected.
watchLoop has been updated to support a context.
Tested with VSCode - I suggest turning auto-save off when using this feature.
Tested again with faas-cli up to make sure there was no regression:
https://asciinema.org/a/594072
Types of changes