Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add showcase author metadata #118

Merged
merged 10 commits into from
Jan 27, 2023
Merged

Add showcase author metadata #118

merged 10 commits into from
Jan 27, 2023

Conversation

clementbiron
Copy link
Collaborator

Add author metadata to showcase and display author name when it is filled.

image

@MattiSG suggests that we change the icon according to the type of author, I find the idea attractive but it's not very easy to find according icons for collective|ngo|research_center|business|local_government|national_government in the lib used. If you find icons in this library that you think work, let me know.

@clementbiron clementbiron requested a review from MattiSG January 20, 2023 13:27
@clementbiron clementbiron linked an issue Jan 20, 2023 that may be closed by this pull request
Add author to showcase entries #114
Closed
@netlify
Copy link

netlify bot commented Jan 20, 2023 •
edited
Loading

✅ Deploy Preview for openfisca-org ready!

Name Link
🔨 Latest commit 583969f
🔍 Latest deploy log https://app.netlify.com/sites/openfisca-org/deploys/63d453db12518b000888f574
😎 Deploy Preview https://deploy-preview-118--openfisca-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MattiSG
Copy link
Member

MattiSG commented Jan 26, 2023

Not perfect, but I believe this could do:

  • collective → users
  • ngo → globe
  • research_center → graduation-cap
  • business → factory
  • local_government → building
  • national_government → landmark

MattiSG
MattiSG approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@clementbiron
Copy link
Collaborator Author

Not perfect, but I believe this could do:

* `collective` → `users`

* `ngo` → `globe`

* `research_center` → `graduation-cap`

* `business` → `factory`

* `local_government` → `building`

* `national_government` → `landmark`

Thank you for this suggestion, I have implemented it.

@MattiSG
Copy link
Member

MattiSG commented Jan 27, 2023 •
edited
Loading

Are we waiting for anything to merge this? 🙂

@clementbiron
Copy link
Collaborator Author

Following our discussion earlier, I am working on it ;)

@clementbiron
Copy link
Collaborator Author

It was much more complicated than I thought but I simplified it well, see aadaa8b: it allowed me to better understand how context is propagated in partials 🧠

@MattiSG I'm sorry I've had a complicated day and I think it's necessary that you review the PR again, especially with the addition of the authors for each reuse, see 091d4aa

@clementbiron clementbiron requested a review from MattiSG January 27, 2023 22:12
MattiSG
MattiSG requested changes Jan 27, 2023
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why Netlify fails when the build passes in CircleCi 🤔

data/showcase/leximpact.yml Outdated Show resolved Hide resolved
data/showcase/mes_aides.yml Outdated Show resolved Hide resolved
data/showcase/nsw_legislation_explorer.yml Outdated Show resolved Hide resolved
data/showcase/rapu_ture.yml Outdated Show resolved Hide resolved
data/showcase/revenu_de_base.yml Outdated Show resolved Hide resolved
@MattiSG
Copy link
Member

MattiSG commented Jan 27, 2023

I'll handle renames 🙂

@MattiSG
Copy link
Member

MattiSG commented Jan 27, 2023

I let two suggestions open as I'm not sure if it is a problem for you that it renders in two lines. For myself, I'm okay with it, but I'll let you decide 🙂
image

MattiSG
MattiSG approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 🚀

@MattiSG MattiSG mentioned this pull request Jan 27, 2023
Merged
@clementbiron clementbiron force-pushed the add_showcase_author_metadata branch from 200bfc5 to 583969f Compare January 27, 2023 22:44
@clementbiron clementbiron merged commit 9a240ac into master Jan 27, 2023
@clementbiron clementbiron deleted the add_showcase_author_metadata branch January 27, 2023 22:46
@MattiSG MattiSG mentioned this pull request Feb 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiSG MattiSG MattiSG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add author to showcase entries
2 participants
@clementbiron @MattiSG