Validate showcase entries data format #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openfisca-org ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Haha, of course that was not true. This should be fixed now. |
|
Several currently failing tests should pass after a rebase on #118, since this changeset checks for metadata that will be added in there 🙂 |
clementbiron
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Great improvements! (and this one is very well catched ^^).
With `npx format-package`
Missing data is set to a default to enable marking the metadata as mandatory
clementbiron
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset enables automatic validation, locally and in CI, of showcase entries. Combined with #110, it will be an important asset in ensuring quality and trust in the contributed data, enabling faster review of contributions and sparing maintainers with manual checks.
Some features (top-level await) used for testing needed a switch to the
moduletype. This should not have any consequence beyond cosmetic changes.I also used this PR to improve the readability of the
package.jsonfile in 676e03c and b9d8ed4. This is tangent to this changeset, so please let me know if you'd prefer me to split this PR in two to ease review 🙂