Build.xml: Add /opt/homebrew/lib
as rpath on arm64 macos
#1783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is where arm64 homebrew installs
libneko.dylib
. However, it may still be in/usr/local/lib
if installed via the haxe .pkg installer, so we add both. See the discussion in: c70ec9f.Closes #1750.
We should use
install_name_tool -delete-rpath [path]
to remove rpaths when copyinglime.ndll
into a cpp build, because we only need the rpath for neko builds (wherelibneko.dylib
is going to be loaded), and having an unnecessary rpath is a security concern. I'm not too sure where to do this, I guess maybe here after copying it? @joshtynjalalime/tools/platforms/MacPlatform.hx
Lines 175 to 178 in c70ec9f